Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update building_a_plugin.mdx #101921

Merged
merged 7 commits into from
Jun 14, 2021

Conversation

stacey-gammon
Copy link
Contributor

  1. Add information about the new owner and description fields.
  2. Add suggestion about considering a package if only static utilities are exported (could probably use a link to what a package is and how to create one, when we have that).
  3. Call out best practices for not using export * on the top level (hopefully we'll lint against that at some point), and also preferring export type over export when possible.
  4. Mention that you don't need to declare a dependency if it's only for types.

Screen Shot 2021-06-10 at 12 24 52 PM

Screen Shot 2021-06-10 at 12 21 54 PM

@stacey-gammon stacey-gammon added release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.14.0 v8.0 labels Jun 10, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@stacey-gammon
Copy link
Contributor Author

@spalger - Added a line about the requiredBundles based on the chat in slack!

@spalger spalger added v8.0.0 and removed v8.0 labels Jun 10, 2021
@stacey-gammon
Copy link
Contributor Author

@elasticmachine merge upstream

@stacey-gammon stacey-gammon enabled auto-merge (squash) June 14, 2021 13:28
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stacey-gammon stacey-gammon merged commit 277212d into elastic:master Jun 14, 2021
@stacey-gammon stacey-gammon added the auto-backport Deprecated - use backport:version if exact versions are needed label Jun 14, 2021
kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Jun 14, 2021
* Update building_a_plugin.mdx

* put back the numbers on the same line

* Add info about requiredBundles

* Fix numbers again

* Update dev_docs/tutorials/building_a_plugin.mdx

Co-authored-by: Mikhail Shustov <[email protected]>

* Update dev_docs/tutorials/building_a_plugin.mdx

Co-authored-by: Mikhail Shustov <[email protected]>

Co-authored-by: Mikhail Shustov <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request Jun 14, 2021
* Update building_a_plugin.mdx

* put back the numbers on the same line

* Add info about requiredBundles

* Fix numbers again

* Update dev_docs/tutorials/building_a_plugin.mdx

Co-authored-by: Mikhail Shustov <[email protected]>

* Update dev_docs/tutorials/building_a_plugin.mdx

Co-authored-by: Mikhail Shustov <[email protected]>

Co-authored-by: Mikhail Shustov <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>

Co-authored-by: Stacey Gammon <[email protected]>
Co-authored-by: Mikhail Shustov <[email protected]>
cuff-links pushed a commit to cuff-links/kibana that referenced this pull request Jun 15, 2021
* Update building_a_plugin.mdx

* put back the numbers on the same line

* Add info about requiredBundles

* Fix numbers again

* Update dev_docs/tutorials/building_a_plugin.mdx

Co-authored-by: Mikhail Shustov <[email protected]>

* Update dev_docs/tutorials/building_a_plugin.mdx

Co-authored-by: Mikhail Shustov <[email protected]>

Co-authored-by: Mikhail Shustov <[email protected]>
Co-authored-by: Kibana Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants