Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] [Fleet] Support granular integrations in policy editor (#101531) #101848

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

kibanamachine
Copy link
Contributor

Backports the following commits to 7.x:

* Adjust packageToPackagePolicy to support multiple policy_templates

* Adjust validatePackagePolicy to support multiple policy templates

* Create input for every policy template input instead of grouping

* Related adjustments for previous commit

* Don't key by policy template when package doesn't have integrations

* Adjust limited package check to support multiple policy templates

* First pass at UI support

* Fix imports, add missing schema

* Fix finding input agent templates, adjust tests

* Only enable specific integrations by default in the UI

* Fix import

* Make breadcrumbs and create package policy page title reflect integration, not package

* Only show specific integration inputs when adding integration to a policy

* Change predicate

* Simplify condition
@kibanamachine
Copy link
Contributor Author

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
fleet 985 1006 +21

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 713.7KB 711.3KB -2.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fleet 425.1KB 433.9KB +8.8KB

Saved Objects .kibana field count

Every field in each saved object type adds overhead to Elasticsearch. Kibana needs to keep the total field count below Elasticsearch's default limit of 1000 fields. Only specify field mappings for the fields you wish to search on or query. See https://www.elastic.co/guide/en/kibana/master/development-plugin-saved-objects.html#_mappings

id before after diff
ingest-package-policies 32 33 +1
Unknown metric groups

API count

id before after diff
fleet 1075 1096 +21

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @jen-huang

@kibanamachine kibanamachine merged commit c7e8e4f into elastic:7.x Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants