-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Detections] Adds automatic updating for Prebuilt Security Detection Rules package #101846
Merged
rw-access
merged 16 commits into
elastic:master
from
rw-access:autoupdate-security-rules-pkg
Jun 24, 2021
+728
−362
Merged
Changes from 8 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
24e2beb
Automatically install and update the security_detection_engine package
rw-access 685ead8
Merge branch 'master' of github.com:elastic/kibana into autoupdate-se…
rw-access 08421dc
Merge branch 'master' into autoupdate-security-rules-pkg
kibanamachine 3a9d38a
Remove security_detection_engine from required Fleet packages
rw-access 4741896
Update fleet package-registry image
rw-access 7d625e3
Add sha256: to the distribution package
rw-access 723e025
Merge remote-tracking branch 'origin/master' into autoupdate-security…
rw-access c98d067
Use distribution from https://beats-ci.elastic.co/job/Ingest-manager/…
rw-access 993d5e3
Change fleet required package
rw-access b21b237
Merge branch 'master' into autoupdate-security-rules-pkg
rw-access a08b7fd
Merge branch 'master' into autoupdate-security-rules-pkg
kibanamachine 953c153
Merge branch 'master' into autoupdate-security-rules-pkg
kibanamachine e1d0e59
Merge branch 'master' into autoupdate-security-rules-pkg
rw-access 3be7957
Fix bad merge
rw-access 0b6212a
Update rules to 0.13.1 package
rw-access 31d23e7
Fix NOTICE.txt
rw-access File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @jfsiii for awareness that this change may overlap with #101911
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks, @jen-huang. @rw-access am I correct that this only needs this SHA for now? i.e. after this lands or, say, 2 weeks from now, we should be able to update using the current approach of
distribution:some_recent_tag
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I just needed a SHA that contained [email protected] (or more recent)
should this be switched to a tag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that sound good to you both @jen-huang and @jfsiii?
please let me know if there are any changes I need to make
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rw-access sorry for the lag, I missed this notification.
I'm fine with leaving as a SHA. After it lands, we can return to a
distribution:*
tag.