[Uptime] Unskip alert functional test #101562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzad31
added
release_note:skip
justinkambic
reviewed
Jun 9, 2021
| @@ -7,10 +7,10 @@ | |||
|
|
|||
| import expect from '@kbn/expect'; | |||
| import { FtrProviderContext } from '../../ftr_provider_context'; | |||
| const delay = (ms: number) => new Promise((resolve) => setTimeout(resolve, ms)); | |||
There was a problem hiding this comment.
I think we don't need to maintain our own delay function. bluebird exports one and it's used in other places.
| @@ -124,7 +126,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => { | |||
| expect(timerangeUnit).to.be('h'); | |||
| expect(timerangeCount).to.be(1); | |||
| expect(JSON.stringify(filters)).to.eql( | |||
| `{"url.port":["5678"],"observer.geo.name":["mpls"],"monitor.type":["http"],"tags":[]}` | |||
| `{"tags":[],"url.port":["5678"],"observer.geo.name":["mpls"],"monitor.type":["http"]}` | |||
There was a problem hiding this comment.
Is there a need for this change or just the result of doing some testing?
There was a problem hiding this comment.
yes, seems like the order has changed.
| schemes: alertParams.filters?.['monitor.type'] ?? [], | ||
| }) | ||
| ); | ||
| if (!window.location.pathname.includes('/app/uptime')) { |
botelastic
bot
added
the
Team:Uptime - DEPRECATED
|
Pinging @elastic/uptime (Team:uptime) |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
shahzad31
added
the
auto-backport
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Jun 10, 2021
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
Jun 10, 2021
Co-authored-by: Shahzad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fix #88177
Unskip uptime functional tests
Flaky test run https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/1615/