-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Security Solution][CTI] Add non-ECS Security Solution and CTI mappings (RAC) #101547
Conversation
Pinging @elastic/security-solution (Team: SecuritySolution) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! I had one note about the ECS compatibility that we'll need to resolve before this can be merged.
@ecezalp could we pair on running this locally? I'd like to see the final output that this produces but I'm a bit behind the RAC curve here.
array: false, | ||
required: false, | ||
}, | ||
'threat.indicator.geo.city_name': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are removing the as
, geo
, and most other nested fields from threat.indicator
as per the current RFC.
If these mappings will be used in 7.14, the current implementation makes sense. If these aren't going to be in effect until 7.15, we should strive to use the fields as presented in the RFC.
* 2.0. | ||
*/ | ||
|
||
export const securityFieldMap = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For posterity: what was the logic used to generate this list of fields?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Answered offline: these are all the fields in the existing signals index that were NOT either:
- part of ECS
- identified as past/current/future CTI fields.
@elasticmachine merge upstream |
@elasticmachine merge upstream |
jenkins, test this (restarting due to jenkins upgrade) |
@elasticmachine merge upstream |
💚 Build SucceededMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @ecezalp |
closing as duplicate of #107977 |
Summary
There are some non-ECS fields within the Security Solution that need to be added to be added to the RAC implementation of rules for backwards compatibility. This commit ensures that all mappings that existed within the security solution continue to exist.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers