[esArchiver] drop support for --dir, use repo-relative paths instead #101345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
force-pushed
the
implement/absolute-test-archive-paths
branch
3 times, most recently
from
ccf1a43 to
df6e744
Compare
spalger
force-pushed
the
implement/absolute-test-archive-paths
branch
from
df6e744 to
c8430bf
Compare
spalger
added
release_note:skip
|
Pinging @elastic/kibana-operations (Team:Operations) |
YulNaumenko
approved these changes
Jun 8, 2021
|
Pinging @elastic/apm-ui (Team:apm) |
poffdeluxe
approved these changes
Jun 8, 2021
jbudz
approved these changes
Jun 8, 2021
mattkime
approved these changes
Jun 8, 2021
spalger
added
the
auto-backport
|
@elasticmachine merge upstream |
|
@elasticmachine merge upstream |
XavierM
approved these changes
Jun 8, 2021
💚 Build Succeeded
Metrics [docs]
History
To update your PR or re-run it, just comment with: |
💔 Backport failed
To backport manually run: |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Jun 8, 2021
…lastic#101345) Co-authored-by: spalger <[email protected]> # Conflicts: # test/api_integration/apis/suggestions/suggestions.js # test/functional/apps/discover/_large_string.ts # test/functional/apps/visualize/index.ts # x-pack/test/functional/apps/infra/feature_controls/logs_security.ts # x-pack/test/functional/apps/saved_objects_management/import_saved_objects_between_versions_6.x_7.x.ts # x-pack/test/functional/apps/upgrade_assistant/upgrade_assistant.ts
spalger
added a commit
that referenced
this pull request
Jun 9, 2021
…stead (#101345) (#101676) * [esArchiver] drop support for --dir, use repo-relative paths instead (#101345) Co-authored-by: spalger <[email protected]> # Conflicts: # test/api_integration/apis/suggestions/suggestions.js # test/functional/apps/discover/_large_string.ts # test/functional/apps/visualize/index.ts # x-pack/test/functional/apps/infra/feature_controls/logs_security.ts # x-pack/test/functional/apps/saved_objects_management/import_saved_objects_between_versions_6.x_7.x.ts # x-pack/test/functional/apps/upgrade_assistant/upgrade_assistant.ts * convert references to `saved_objects/basic` archive * adapt other `saved_objects/*` archives * update management/saved_obejcts/relationships archives * replace old monitoring setup() usage * remove reference to `empty_kibana` archive Co-authored-by: spalger <[email protected]>
tylersmalley
pushed a commit
that referenced
this pull request
Jun 9, 2021
PR's merged after #101345 Signed-off-by: Tyler Smalley <[email protected]>
tylersmalley
pushed a commit
that referenced
this pull request
Jun 9, 2021
PR's merged after #101345 Signed-off-by: Tyler Smalley <[email protected]>
tylersmalley
pushed a commit
that referenced
this pull request
Jun 9, 2021
PR's merged after #101345 Signed-off-by: Tyler Smalley <[email protected]>
tylersmalley
pushed a commit
that referenced
this pull request
Jun 9, 2021
PR's merged after #101345 Signed-off-by: Tyler Smalley <[email protected]>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jun 9, 2021
* master: (54 commits) Implement "select all" rules feature (elastic#100554) [ML] Remove script fields from the Anomaly detection alerting rule executor (elastic#101607) [Security solutions][Endpoint] Update event filtering texts (elastic#101563) [Enterprise Search] Mocks/tests tech debt - avoid hungry mocking (elastic#101107) [FTR] Updates esArchive paths [FTR] Updates esArchive paths [Security Solution][Detection Engine] Adds runtime field tests (elastic#101664) Added APM PHP agent to the list of agent names (elastic#101062) [CI] Restore old version_info behavior when .git directory is present (elastic#101642) [Fleet] Add fleet server telemetry (elastic#101400) [APM] Syncs agent config settings to APM Fleet policies (elastic#100744) [esArchiver] drop support for --dir, use repo-relative paths instead (elastic#101345) Revert "[xpack/test] restore incremental: false in ts project" [Security Solution] Remove Host Isolation feature flag (elastic#101655) [xpack/test] restore incremental: false in ts project [DOCS] Adds link to video landing page (elastic#101413) [ML] Move Index Data Visualizer into separate plugin (Part 1) (elastic#100922) Improve security plugin return types (elastic#101492) [ts] migrate `x-pack/test` to composite ts project (elastic#101441) [App Search] Updated Search UI to new URL (elastic#101320) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have recently been making changes to tests and found the location of esArchives to be very confusing, especially since the archive name
empty_kibanaresolves to different archives for different parts of the code base, and it's not clear where the archives are. Additionally, we want it to be easier to share archives across tests configs, so this change removes the concept of an esArchiver dir and instead requires that all calls toesArchiverAPIs use repo-relative paths like so:This should make it crystal clear to all readers where archives are in the repo and hopefully encourage most archives to move into a more central shared location where people can reuse certain useful archives.