Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.x] [Reporting/Telemetry] Do not send telemetry if we are in screenshot mode (#100388) #101076

Merged
merged 1 commit into from
Jun 1, 2021
Merged

[7.x] [Reporting/Telemetry] Do not send telemetry if we are in screenshot mode (#100388) #101076

merged 1 commit into from
Jun 1, 2021

Conversation

jloleysens
Copy link
Contributor

Backports the following commits to 7.x:

@jloleysens
[Reporting/Telemetry] Do not send telemetry if we are in screenshot m…
687f2a9 
…ode (elastic#100388)

* do not send telemetry if isScreenshotMode

* Implement PR feedback:

* added another Jest test
* move Boolean() to make the opt-in value always boolean

* remove unused import and convert to import type

* fix type issues

* update jest snapshot

* Expanded test coverage

- added plugin functional test
- added jest test to check TelemetrySender behaviour
- exported the localStorage/window value that flags screenshot
  mode

* fix test plugin name in package.json and make sure to opt out of telemetry when the test finishes

* added missing type file to plugin_functional test

Co-authored-by: Kibana Machine <[email protected]>
# Conflicts:
#	src/plugins/telemetry/kibana.json
@jloleysens jloleysens enabled auto-merge (squash) June 1, 2021 17:36
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
screenshotMode 11 16 +5

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id before after diff
screenshotMode 0 1 +1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
screenshotMode 3.0KB 3.2KB +191.0B
telemetry 36.4KB 36.8KB +397.0B
total +588.0B
Unknown metric groups

API count

id before after diff
screenshotMode 15 21 +6
telemetry 41 42 +1
total +7

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 22 20 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 256 146 -110
lens 67 45 -22
licensing 18 15 -3
lists 239 236 -3
maps 286 208 -78
ml 121 115 -6
monitoring 109 56 -53
total -290

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@jloleysens jloleysens merged commit 09129c8 into elastic:7.x Jun 1, 2021
@jloleysens jloleysens deleted the backport/7.x/pr-100388 branch June 2, 2021 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
backport
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jloleysens @kibanamachine