-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Batch mget requests on dashboard load and cache field_stat results #10081
Merged
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
5c1344e
defer loading visualization saved objects so they can be loaded in a …
nreese 96af3ea
Merge branch 'defer' of https://github.com/nreese/kibana into nreese-…
stacey-gammon 9a02e5b
Don't request field stats more than once for the same index pattern
stacey-gammon 20d55fe
[ui/courier] batch fetch requests for all searches and docs
spalger f5bd5ca
[ui/courier] remove remaining mentions of req.isFetchRequested()
spalger eb5446d
[courier/fetch/request] remove unneceessary !!
spalger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,6 +15,8 @@ export default function FetchStrategyForSearch(Private, Promise, timefilter, kbn | |
* @return {Promise} - a promise that is fulfilled by the request body | ||
*/ | ||
reqsFetchParamsToBody: function (reqsFetchParams) { | ||
const indexToListMapping = {}; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
|
||
return Promise.map(reqsFetchParams, function (fetchParams) { | ||
return Promise.resolve(fetchParams.index) | ||
.then(function (indexList) { | ||
|
@@ -23,7 +25,11 @@ export default function FetchStrategyForSearch(Private, Promise, timefilter, kbn | |
} | ||
|
||
const timeBounds = timefilter.getBounds(); | ||
return indexList.toIndexList(timeBounds.min, timeBounds.max); | ||
|
||
if (!indexToListMapping[indexList.id]) { | ||
indexToListMapping[indexList.id] = indexList.toIndexList(timeBounds.min, timeBounds.max); | ||
} | ||
return indexToListMapping[indexList.id]; | ||
}) | ||
.then(function (indexList) { | ||
let body = fetchParams.body || {}; | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the need for the double negative? Is it to avoid the undefined case? It'll still all work as expected right? Maybe just initialize this._fetchRequested to false in that case?
Just seems a little strange when the value is essentially a boolean, and the double negative requires an extra extra brain cycle or two to make the conversion. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forces boolean
true
out of anything. I agree that it's unusual since it's part of a larger boolean statement and now I wonder if there's more to the trick than I remember or just a force of habit.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, when it was just returning the value of
_fetchRequested
I was a little more concerned about it always being a boolean value, but now that it's returning the&&
calculation it's totally unnecessary.