[ML] Fix categorization job view examples link when datafeed uses multiple indices #100789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peteharverson
added
review
release_note:fix
:ml
Feature:Anomaly Detection
|
Pinging @elastic/ml-ui (:ml) |
|
|
||
| kibanaSettings.discoverIndexPatternId = defaultIndexPattern.id; | ||
| const defaultIndexPatternId = | ||
| getIndexPatternIdFromName(datafeedConfig.indices.join()) || indexPatterns[0].id; |
There was a problem hiding this comment.
we should use ?? rather than || for checks like this
There was a problem hiding this comment.
Fixed in 920f98c
jgowdyelastic
approved these changes
May 28, 2021
qn895
approved these changes
May 28, 2021
|
Tested and LGTM |
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Unknown metric groupsReferences to deprecated APIs
History
To update your PR or re-run it, just comment with: |
peteharverson
added a commit
to peteharverson/kibana
that referenced
this pull request
May 28, 2021
…tiple indices (elastic#100789) * [ML] Fix categorization job view examples link when datafeed uses multiple indices * [ML] Fix operator in index pattern check Co-authored-by: Kibana Machine <[email protected]>
peteharverson
added a commit
that referenced
this pull request
May 28, 2021
…tiple indices (#100789) (#100923) * [ML] Fix categorization job view examples link when datafeed uses multiple indices * [ML] Fix operator in index pattern check Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
May 28, 2021
* master: (77 commits) [RAC][Security Solution] Register Security Detection Rules with Rule Registry (elastic#96015) [Enterprise Search] Log warning for Kibana/EntSearch version mismatches (elastic#100809) updating the saved objects test to include more saved object types (elastic#100828) [ML] Fix categorization job view examples link when datafeed uses multiple indices (elastic#100789) Fixing ES archive mapping failure (elastic#100835) Fix bug with Observability > APM header navigation (elastic#100845) [Security Solution][Endpoint] Add event filters summary card to the fleet endpoint tab (elastic#100668) [Actions] Taking space id into account when creating email footer link (elastic#100734) Ensure comments on parameters in arrow functions are captured in the docs and ci metrics. (elastic#100823) [Security Solution] Improve find rule and find rule status route performance (elastic#99678) [DOCS] Adds video to introduction (elastic#100906) [Fleet] Improve combo box for fleet settings (elastic#100603) [Security Solution][Endpoint] Endpoint generator and data loader support for Host Isolation (elastic#100813) [DOCS] Adds Lens video (elastic#100898) [TSVB] [Table tab] Fix "Math" aggregation (elastic#100765) chore(NA): moving @kbn/io-ts-utils into bazel (elastic#100810) [Alerting] Adding feature flag for enabling/disabling rule import and export (elastic#100718) [TSVB] Fix Upgrading from 7.12.1 to 7.13.0 breaks TSVB (elastic#100864) [Lens] Adds dynamic table cell coloring (elastic#95217) [Security Solution][Endpoint] Do not display searchbar in security-trusted apps if there are no items (elastic#100853) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the link to view examples from the anomalies table for a categorization anomaly detection job in Discover when the datafeed uses more than one index.
Previously the
View exampleslink would only use the first index in the list, so would not correctly select the comma separated index pattern used by the job when opening Discover.Example for a job which has this
indicessetting in the datafeed:Before (tries to select the first index in the list):
After:
Also fixed the default index pattern selection when creating a Discover type custom URL when the index pattern used by the job contains more than one index.
Before (selects first index from the list):
After (defaults to index pattern used by the job):
Checklist
Fixes #100328