[TSVB] Math params._interval is incorrect when using entire timerange mode #100775

alexwizp · 2021-05-27T13:24:33Z

Summary

params._interval is used to normalize the display of values, for example to get an average rate per second. When using the entire timerange mode, it should represent the total number of milliseconds in the time range.

Steps to reproduce:

Set the following value for the Timerange control
Open TSVB and add a Math function. Type params._interval into the math input.
Switch to the Metric visualization type.
Open Panel Options, then choose "Last value" timerange mode instead. Notice that the interval is the same.

Expected behavior: The params._interval is set to the number of milliseconds in the query, the to - from time.

Screens

Entire time range mode
Last value mode

… mode Closes: elastic#100615

alexwizp · 2021-05-27T13:28:58Z

...ins/vis_type_timeseries/server/lib/vis_data/request_processors/series/date_histogram.test.js

@@ -86,8 +86,7 @@ describe('dateHistogram(req, panel, series)', () => {
            },
          },
          meta: {
-            bucketSize: 10,


bucketSize was removed to avoid of any calculation in future, cause in fact we need a interval

alexwizp · 2021-05-27T13:39:41Z

src/plugins/vis_type_timeseries/server/lib/vis_data/response_processors/table/math.js

@@ -8,9 +8,9 @@

 import { mathAgg } from '../series/math';

-export function math(bucket, panel, series) {
+export function math(bucket, panel, series, meta, extractFields) {


a separate PR (#100765) was created for that change which should be backported into 7.13.2

Kuznietsov

LGTM. Tested locally, everything works as expected.

src/plugins/vis_type_timeseries/server/lib/vis_data/request_processors/series/date_histogram.js

alexwizp · 2021-05-28T12:57:17Z

@elasticmachine merge upstream

alexwizp · 2021-05-31T08:54:17Z

@elasticmachine merge upstream

elasticmachine · 2021-05-31T13:11:42Z

Pinging @elastic/kibana-app (Team:KibanaApp)

stratoula · 2021-06-01T07:57:33Z

@alexwizp I think the same problem with Math also happens with Bucket script. Do you think we could solve this in this PR?

alexwizp · 2021-06-01T13:48:01Z

src/plugins/vis_type_timeseries/server/lib/vis_data/helpers/bucket_transform.js

    const body = {
      derivative: {
        buckets_path: getBucketsPath(bucket.field, metrics),
        gap_policy: 'skip', // seems sane
-        unit: bucketSize,
+        unit: intervalString,


according to the documentation there should be a string value here, not the size of the bucket

https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-pipeline-derivative-aggregation.html#_units

src/plugins/vis_type_timeseries/server/lib/vis_data/request_processors/table/date_histogram.js

VladLasitsa

LGTM! Tested locally in chrome

kibanamachine · 2021-06-02T13:44:44Z

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id	before	after	diff
`canvas`	29	25	-4
`crossClusterReplication`	8	6	-2
`fleet`	22	20	-2
`globalSearch`	4	2	-2
`indexManagement`	12	7	-5
`infra`	261	149	-112
`lens`	67	45	-22
`licensing`	18	15	-3
`lists`	239	236	-3
`maps`	286	208	-78
`ml`	121	115	-6
`monitoring`	109	56	-53
`securitySolution`	390	346	-44
`stackAlerts`	101	95	-6
total			-342

History

💚 Build #128355 succeeded 2ceeb47
💚 Build #128146 succeeded a84b06da3aebe5e63a90ac49f0937d0622cdb44c
💚 Build #127897 succeeded 9922d44
💔 Build #127841 failed 800e665
💔 Build #127662 failed 6c245d3

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @alexwizp

stratoula

My dear Alexey, math and bucket script seem to work ok now. I did some tests and I think we are fine

… mode (elastic#100775) * [TSVB] Math params._interval is incorrect when using entire timerange mode Closes: elastic#100615 * fix jest * rename get -> overwrite * apply fix for "bucket script" * Update date_histogram.js Co-authored-by: Kibana Machine <[email protected]>

kibanamachine · 2021-06-03T09:40:50Z

💚 Backport successful

Status	Branch	Result
✅	7.x

This backport PR will be merged automatically after passing CI.

… mode (#100775) (#101252) * [TSVB] Math params._interval is incorrect when using entire timerange mode Closes: #100615 * fix jest * rename get -> overwrite * apply fix for "bucket script" * Update date_histogram.js Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Alexey Antonov <[email protected]>

[TSVB] Math params._interval is incorrect when using entire timerange…

6c245d3

… mode Closes: elastic#100615

alexwizp commented May 27, 2021

View reviewed changes

alexwizp requested review from VladLasitsa and Kuznietsov May 27, 2021 13:37

alexwizp commented May 27, 2021

View reviewed changes

alexwizp requested a review from wylieconlon May 27, 2021 13:40

alexwizp self-assigned this May 27, 2021

alexwizp added v7.14.0 v8.0.0 Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:TSVB TSVB (Time Series Visual Builder) release_note:fix labels May 27, 2021

alexwizp requested a review from DianaDerevyankina May 27, 2021 13:42

alexwizp added the auto-backport Deprecated - use backport:version if exact versions are needed label May 27, 2021

fix jest

800e665

Kuznietsov approved these changes May 28, 2021

View reviewed changes

src/plugins/vis_type_timeseries/server/lib/vis_data/request_processors/series/date_histogram.js Outdated Show resolved Hide resolved

src/plugins/vis_type_timeseries/server/lib/vis_data/request_processors/series/date_histogram.js Outdated Show resolved Hide resolved

kibanamachine and others added 2 commits May 28, 2021 08:57

Merge branch 'master' into 100615

b110d02

rename get -> overwrite

9922d44

alexwizp marked this pull request as ready for review May 31, 2021 13:11

alexwizp requested a review from a team May 31, 2021 13:11

stratoula mentioned this pull request Jun 1, 2021

Params._interval returning null for Table in TSVB #101022

Closed

alexwizp added 2 commits June 1, 2021 16:44

apply fix for "bucket script"

74288d5

Merge remote-tracking branch 'upstream/master' into 100615

2ceeb47

alexwizp force-pushed the 100615 branch from a84b06d to 2ceeb47 Compare June 1, 2021 13:45

alexwizp commented Jun 1, 2021

View reviewed changes

VladLasitsa reviewed Jun 2, 2021

View reviewed changes

src/plugins/vis_type_timeseries/server/lib/vis_data/request_processors/table/date_histogram.js Outdated Show resolved Hide resolved

Update date_histogram.js

5ef6b20

VladLasitsa approved these changes Jun 2, 2021

View reviewed changes

stratoula approved these changes Jun 3, 2021

View reviewed changes

alexwizp merged commit 83b47c1 into elastic:master Jun 3, 2021

kibanamachine mentioned this pull request Jun 3, 2021

[7.x] [TSVB] Math params._interval is incorrect when using entire timerange mode (#100775) #101252

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[TSVB] Math params._interval is incorrect when using entire timerange mode #100775

[TSVB] Math params._interval is incorrect when using entire timerange mode #100775

alexwizp commented May 27, 2021 •

edited

Loading

alexwizp May 27, 2021

alexwizp May 27, 2021

Kuznietsov left a comment

alexwizp commented May 28, 2021

alexwizp commented May 31, 2021

elasticmachine commented May 31, 2021

stratoula commented Jun 1, 2021

alexwizp Jun 1, 2021

VladLasitsa left a comment

kibanamachine commented Jun 2, 2021

References to deprecated APIs

stratoula left a comment

kibanamachine commented Jun 3, 2021

[TSVB] Math params._interval is incorrect when using entire timerange mode #100775

[TSVB] Math params._interval is incorrect when using entire timerange mode #100775

Conversation

alexwizp commented May 27, 2021 • edited Loading

Summary

Steps to reproduce:

Screens

alexwizp May 27, 2021

Choose a reason for hiding this comment

alexwizp May 27, 2021

Choose a reason for hiding this comment

Kuznietsov left a comment

Choose a reason for hiding this comment

alexwizp commented May 28, 2021

alexwizp commented May 31, 2021

elasticmachine commented May 31, 2021

stratoula commented Jun 1, 2021

alexwizp Jun 1, 2021

Choose a reason for hiding this comment

VladLasitsa left a comment

Choose a reason for hiding this comment

kibanamachine commented Jun 2, 2021

💚 Build Succeeded

Metrics [docs]

References to deprecated APIs

History

stratoula left a comment

Choose a reason for hiding this comment

kibanamachine commented Jun 3, 2021

💚 Backport successful

alexwizp commented May 27, 2021 •

edited

Loading