[Reporting] Make "ScreenCapturePanel" shareable for Canvas #100623

tsullivan · 2021-05-26T01:05:27Z

Summary

This PR adds code in the Reporting public plugin that is exposed on the plugin contract, for the purpose of sharing with Canvas app and removing redundant UI code from Canvas. The effect of doing this refactoring is fixing UI inconsistencies between Canvas app and Dashboard app.

Closes:

[Reporting/Canvas] Report job status notifier does not link to Management > Reporting when job is started #99092 (ui inconsistency)
[Reporting] Refactor public plugin to expose shareable panel components #101078 (refactoring issue)

Checklist

Delete any items that are not applicable to this PR.

Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Unit or functional tests were updated or added to match the most common scenarios
Any UI touched in this PR is usable by keyboard only (learn more about keyboard accessibility)
This renders correctly on smaller devices using a responsive layout. (You can test this in your browser)

tsullivan · 2021-06-02T04:52:38Z

x-pack/plugins/reporting/public/components/screen_capture_panel_content.tsx

 }

 export class ScreenCapturePanelContent extends Component<Props, State> {
  constructor(props: Props) {
    super(props);

-    const { objectType } = props.getJobParams();
-    const isPreserveLayoutSupported = props.reportType !== 'png' && objectType !== 'visualization';


Removed this since elsewhere in the code it's fine/expected for PNG layout to provide "preserve" layout as the option. Therefore, preserve layout is always supported.

elasticmachine · 2021-06-02T19:58:01Z

Pinging @elastic/kibana-app-services (Team:AppServices)

elasticmachine · 2021-06-02T19:58:02Z

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

jloleysens

I still need to finish testing locally, left a couple questions!

jloleysens · 2021-06-03T14:48:30Z

x-pack/plugins/reporting/public/components/shared/get_shared_components.tsx

+      return (
+        <ScreenCapturePanelContent
+          layoutOption={props.layoutOption}
+          requiresSavedState={false}


I know the intention is to make this available to Canvas, but I wonder whether still should not treat this as through it could be placed anywhere (like in Dashboard?). If it is the case that we want to treat it as though it can be used anywhere then I think we should not hardcode this value but rather have the consumer pass it through to us since PDFs, in certain context, do still require saved state. WDYT?

I agree with you it's cleaner to treat this as if it could be used in Dashboard. I don't want to get too deep yet in perfecting the integration touchpoints for the reporting panel. There will be future tech debt / refactoring work to move the export implementation logic out of Reporting, and have new plugins that provide export implementation. That will affect the integration touchpoints, because apps would go from importing this panel component from Reporting, to importing it from a new plugin that controls the implementation detail of the export.

current: <services.reporting.components.ReportingPanelPDF />

future: <services.exportPDF.components.ReportingPanelPDF />

That is why this PR does not change the Reporting plugin contract further, for example it doesn't add CSV or PNG export panel to the contract.

This is a good note for any reviewer - I'll update the description to talk about this.

cc @ppisljar

There will be future tech debt / refactoring work to move the export implementation logic out of Reporting, and have new plugins that provide export implementation

Related Discuss issue: #101422

jloleysens · 2021-06-04T15:37:03Z

x-pack/plugins/reporting/public/components/screen_capture_panel_content.tsx

  };

-  private getLayout = () => {
+  private handleCanvasLayoutChange = (evt: EuiSwitchEvent) => {
+    this.setState({ useCanvasLayout: evt.target.checked, usePrintLayout: false });


The UX here looks like if the user presses the canvas switch (say it is in the "off" position) it will set usePrintLayout to false. Pressing it again will leave usePrintLayout in false. I guess this leaves in in the "default" layout which would be "X"?

I'm wondering, if these controls are related in this way (cannot choose one while we've chosen the other) whether a button group component or similar might not be more appropriate i.t.o. UX. Open to other thoughts here!

OK, I see I was mistaken on this one. Looking at the private renderOptions function I thought that we would render two toggles in some instances but then I saw the isPrintLayoutSupported and isCanvasLayoutSupported are mutually exclusive values that are determined at component mount.

IMO it would be clearer for readers if we read:

if (this.state.isPrintLayoutSupported) as if (this.props.layoutOption === 'print') and chained the if as else if ... for the subsequent canvas layout check to communicate their mutual exclusivity. This is a nit, won't block on this!

jloleysens · 2021-06-07T08:31:09Z

@elasticmachine merge upstream

jloleysens

I tested both Canvas and the example reporting plugins locally and both worked as intended. Great work @tsullivan !

I did not in the example plugin the canvas layout option and the pdf layout option linked to an empty panel which made the example a bit incomplete.

Won't block you on this though, but it might be worth updating.

poffdeluxe

This looks good to me over. One thing that I noticed: if you have reporting enabled but don't have the correct license type and you attempt to generate a PDF, you get a toast notification that just says "Forbidden" where I think previously you'd get a mention about needing to update your license.

tsullivan · 2021-06-08T00:52:56Z

@elasticmachine merge upstream

tsullivan · 2021-06-08T18:28:10Z

One thing that I noticed: if you have reporting enabled but don't have the correct license type and you attempt to generate a PDF, you get a toast notification that just says "Forbidden" where I think previously you'd get a mention about needing to update your license.

That seems like a regression bug: the feature controls that guard Reporting should be aware of the license as well as the application privileges from the user role. I'll look into it.

kibanamachine · 2021-06-10T00:03:15Z

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`canvas`	1090	1089	-1
`reporting`	49	51	+2
total			+1

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`reporting`	132	131	-1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`canvas`	1.3MB	1.3MB	-4.7KB

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`reporting`	19	18	-1

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`canvas`	534.7KB	530.9KB	-3.7KB
`reporting`	84.4KB	85.5KB	+1.1KB
total			-2.6KB

Unknown metric groups

API count

id	before	after	diff
`reporting`	133	132	-1

History

💔 Build #130237 failed 16f7701
💔 Build #130011 failed b37a660
💚 Build #129913 succeeded 1a1c9dc
💚 Build #129674 succeeded 173a3b8
💚 Build #129661 succeeded b17cdf9

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

…00623) * use ScreenCapturePanel component in Canvas * use smaller state object * add comment about canvas-specific shared component * fix example * fix toast error * fix i18n * fix data-test-subj Co-authored-by: Kibana Machine <[email protected]>

…0623) (#101852) * [Reporting] Make "ScreenCapturePanel" shareable for Canvas (#100623) * use ScreenCapturePanel component in Canvas * use smaller state object * add comment about canvas-specific shared component * fix example * fix toast error * fix i18n * fix data-test-subj Co-authored-by: Kibana Machine <[email protected]> * fix compatibility type ts Co-authored-by: Kibana Machine <[email protected]>

…add-agent-flyout * 'master' of github.com:elastic/kibana: (35 commits) [Cases] Improve connectors mapping (elastic#101145) [ML] Fixes display of job group badges in recognizer wizard (elastic#101775) Fix es_archives path (elastic#101737) [kbnArchiver] convert archive names to root-relative paths (elastic#101839) [Reporting] Make "ScreenCapturePanel" shareable for Canvas (elastic#100623) [Alerting UI] Converted Rules and Connectors management pages to new layout. (elastic#101697) [Fleet] Support granular integrations in policy editor (elastic#101531) [Security Solution][Detections] Update detection alert mappings to ECS v1.10.0 (elastic#101680) [Fleet] Integrations UI: Adjust policies list UI (elastic#101600) chore(NA): moving @kbn/server-route-repository into bazel (elastic#101484) Support owner and description attributes inside the Manifest file, use in API docs (elastic#101786) [Security Solution] fix security empty overview links (elastic#101536) Unskips migration tests now that elastic search is fixed (elastic#101682) Fix endpoint -> integrations onboarding link (elastic#101804) [Alerting] Log warning when rules are not rescheduled due to Saved Object not found error (elastic#101591) Update datafeed_high_count_network_denies.json (elastic#101681) [Index patterns] Field editor example app (elastic#100524) [DOCS] Adding file upload to add data page (elastic#101674) [Security Solution][Endpoint] Adds Endpoint Host Isolation Status common component (elastic#101782) Upgrade ws v7.3.1->v7.4.2 and v6.2.1->v6.2.2 (elastic#101402) ... # Conflicts: # x-pack/plugins/fleet/public/components/agent_enrollment_flyout/agent_policy_selection.tsx # x-pack/plugins/fleet/public/components/agent_enrollment_flyout/index.tsx # x-pack/plugins/fleet/public/components/agent_enrollment_flyout/managed_instructions.tsx # x-pack/plugins/fleet/public/components/agent_enrollment_flyout/standalone_instructions.tsx

…add-integrations-redirect * 'master' of github.com:elastic/kibana: (44 commits) Allow navigating discover flyout via arrow keys (elastic#101772) [Cases] Improve connectors mapping (elastic#101145) [ML] Fixes display of job group badges in recognizer wizard (elastic#101775) Fix es_archives path (elastic#101737) [kbnArchiver] convert archive names to root-relative paths (elastic#101839) [Reporting] Make "ScreenCapturePanel" shareable for Canvas (elastic#100623) [Alerting UI] Converted Rules and Connectors management pages to new layout. (elastic#101697) [Fleet] Support granular integrations in policy editor (elastic#101531) [Security Solution][Detections] Update detection alert mappings to ECS v1.10.0 (elastic#101680) [Fleet] Integrations UI: Adjust policies list UI (elastic#101600) chore(NA): moving @kbn/server-route-repository into bazel (elastic#101484) Support owner and description attributes inside the Manifest file, use in API docs (elastic#101786) [Security Solution] fix security empty overview links (elastic#101536) Unskips migration tests now that elastic search is fixed (elastic#101682) Fix endpoint -> integrations onboarding link (elastic#101804) [Alerting] Log warning when rules are not rescheduled due to Saved Object not found error (elastic#101591) Update datafeed_high_count_network_denies.json (elastic#101681) [Index patterns] Field editor example app (elastic#100524) [DOCS] Adding file upload to add data page (elastic#101674) [Security Solution][Endpoint] Adds Endpoint Host Isolation Status common component (elastic#101782) ... # Conflicts: # x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/create_package_policy_page/index.tsx # x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/details_page/components/package_policies/package_policies_table.tsx

* use ScreenCapturePanel component in Canvas * use smaller state object * add comment about canvas-specific shared component * fix example * fix toast error * fix i18n * fix data-test-subj Co-authored-by: Kibana Machine <[email protected]>

tsullivan requested a review from a team as a code owner May 26, 2021 01:05

tsullivan marked this pull request as draft May 26, 2021 01:05

tsullivan force-pushed the reporting/canvas-job-notifier-shared branch 2 times, most recently from 4028fbb to 4f70988 Compare May 27, 2021 02:55

tsullivan mentioned this pull request May 27, 2021

[Reporting/Canvas] Report job status notifier does not link to Management > Reporting when job is started #99092

Closed

tsullivan force-pushed the reporting/canvas-job-notifier-shared branch 5 times, most recently from 6f5cfa0 to 424b165 Compare June 2, 2021 04:38

tsullivan commented Jun 2, 2021

View reviewed changes

tsullivan force-pushed the reporting/canvas-job-notifier-shared branch 3 times, most recently from 188a0b8 to 0887c3b Compare June 2, 2021 17:16

tsullivan added (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Team:AppServices v7.14.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Jun 2, 2021

tsullivan marked this pull request as ready for review June 2, 2021 19:57

tsullivan requested review from dokmic, jloleysens and a team June 2, 2021 19:58

tsullivan force-pushed the reporting/canvas-job-notifier-shared branch from 0887c3b to 234c5f5 Compare June 2, 2021 23:14

use ScreenCapturePanel component in Canvas

112fb42

tsullivan force-pushed the reporting/canvas-job-notifier-shared branch from 234c5f5 to 112fb42 Compare June 2, 2021 23:23

tsullivan requested a review from poffdeluxe June 2, 2021 23:23

jloleysens reviewed Jun 4, 2021

View reviewed changes

tsullivan mentioned this pull request Jun 4, 2021

[Reporting] Redesign app integration with Reporting #101422

Closed

Merge branch 'master' into reporting/canvas-job-notifier-shared

6bf18d9

jloleysens approved these changes Jun 7, 2021

View reviewed changes

poffdeluxe approved these changes Jun 7, 2021

View reviewed changes

kibanamachine and others added 4 commits June 7, 2021 20:52

Merge branch 'master' into reporting/canvas-job-notifier-shared

b17cdf9

use smaller state object

bec3a99

add comment about canvas-specific shared component

173a3b8

fix example

1a1c9dc

tsullivan added 7 commits June 8, 2021 18:10

Merge branch 'master' into reporting/canvas-job-notifier-shared

8d4181e

fix toast error

b37a660

Merge branch 'master' into reporting/canvas-job-notifier-shared

d6ca89e

fix i18n

16f7701

Merge branch 'master' into reporting/canvas-job-notifier-shared

96dd961

Merge branch 'master' into reporting/canvas-job-notifier-shared

f2b91e5

fix data-test-subj

c341617

tsullivan merged commit 3559d37 into elastic:master Jun 10, 2021

tsullivan deleted the reporting/canvas-job-notifier-shared branch June 10, 2021 00:08

tsullivan mentioned this pull request Jun 10, 2021

[7.x] [Reporting] Make "ScreenCapturePanel" shareable for Canvas (#100623) #101852

Merged

tsullivan mentioned this pull request Jul 30, 2021

[Reporting] Refactor public plugin to expose shareable panel components #101078

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Reporting] Make "ScreenCapturePanel" shareable for Canvas #100623

[Reporting] Make "ScreenCapturePanel" shareable for Canvas #100623

tsullivan commented May 26, 2021 •

edited

Loading

tsullivan Jun 2, 2021

elasticmachine commented Jun 2, 2021

elasticmachine commented Jun 2, 2021

jloleysens left a comment

jloleysens Jun 3, 2021

tsullivan Jun 4, 2021

tsullivan Jun 4, 2021

jloleysens Jun 4, 2021 •

edited

Loading

jloleysens Jun 7, 2021

jloleysens commented Jun 7, 2021

jloleysens left a comment

poffdeluxe left a comment

tsullivan commented Jun 8, 2021

tsullivan commented Jun 8, 2021

kibanamachine commented Jun 10, 2021

API count

[Reporting] Make "ScreenCapturePanel" shareable for Canvas #100623

[Reporting] Make "ScreenCapturePanel" shareable for Canvas #100623

Conversation

tsullivan commented May 26, 2021 • edited Loading

Summary

Checklist

tsullivan Jun 2, 2021

Choose a reason for hiding this comment

elasticmachine commented Jun 2, 2021

elasticmachine commented Jun 2, 2021

jloleysens left a comment

Choose a reason for hiding this comment

jloleysens Jun 3, 2021

Choose a reason for hiding this comment

tsullivan Jun 4, 2021

Choose a reason for hiding this comment

tsullivan Jun 4, 2021

Choose a reason for hiding this comment

jloleysens Jun 4, 2021 • edited Loading

Choose a reason for hiding this comment

jloleysens Jun 7, 2021

Choose a reason for hiding this comment

jloleysens commented Jun 7, 2021

jloleysens left a comment

Choose a reason for hiding this comment

poffdeluxe left a comment

Choose a reason for hiding this comment

tsullivan commented Jun 8, 2021

tsullivan commented Jun 8, 2021

kibanamachine commented Jun 10, 2021

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Async chunks

Public APIs missing exports

Page load bundle

API count

History

tsullivan commented May 26, 2021 •

edited

Loading

jloleysens Jun 4, 2021 •

edited

Loading