-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] Isolate mapbox-gl types and align downstream package versions. #100610
[Maps] Isolate mapbox-gl types and align downstream package versions. #100610
Conversation
apparently, upgrading the packages (69509a1) causes a failed build. without the upgrade (9bdb959), it succeeds OK https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/127255/ [EDIT] This is due to introduction of top-level |
Pinging @elastic/kibana-gis (Team:Geo) |
💚 Build SucceededMetrics [docs]Module Count
Async chunks
Unknown metric groupsReferences to deprecated APIs
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, code review only on the vega plugin 🙂
Are we going to add an owner to the new package?
@stratoula yes, good idea- maps should own that package. I'll add it to codeowners. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
code review
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
…#100610) (#100752) Co-authored-by: Thomas Neirynck <[email protected]>
Isolates mapbox-gl types into bazel.
This PR makes following changes:
kbn/mapbox-gl
packageLayer
->AnyLayer
.type
. This makes a small dent in bundle size.This should be the last PR before #85566. The MapLibre switch should then be isolated to:
mapbox-gl
andtypes/mapbox-gl
dependecies of the package