Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alerting] Update README #100478

Merged
merged 3 commits into from
May 24, 2021
Merged

[Alerting] Update README #100478

merged 3 commits into from
May 24, 2021

Conversation

ymao1
Copy link
Contributor

@ymao1 ymao1 commented May 24, 2021

Summary

Updated Alerting README to reflect updated terminology. Also updated some sections that should have been updated with recent PR changes.

|tags|The tags associated with this rule. This will eventually be removed in favor of `rule.tags`.|
|createdBy|The user ID of the user that created this rule. This will eventually be removed in favor of `rule.createdBy`.|
|updatedBy|The user ID of the user that last updated this rule. This will eventually be removed in favor of `rule.updatedBy`.|
|rule.name|The name of this rule.|
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These rule inputs were added in this PR

- `get`
- `getAlertState`
- `getRuleState`
- `getAlertSummary`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These privilege strings were updated in this PR

@ymao1 ymao1 self-assigned this May 24, 2021
@ymao1 ymao1 added Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.14.0 v8.0.0 labels May 24, 2021
@ymao1 ymao1 marked this pull request as ready for review May 24, 2021 17:00
@ymao1 ymao1 requested a review from a team as a code owner May 24, 2021 17:00
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

## Terminology

**Alert Type**: A function that takes parameters and executes actions to alert instances.
> Disclaimer: We are actively working to update the terminology of the Alerting Framework. While all user-facing terminology has been updated, much of the codebase is still a work in progress.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Terminology disclaimer added here.

Copy link
Contributor

@YulNaumenko YulNaumenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
crossClusterReplication 8 6 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 261 149 -112
lens 67 45 -22
licensing 18 15 -3
total -146

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @ymao1

@ymao1 ymao1 added the auto-backport Deprecated - use backport:version if exact versions are needed label May 24, 2021
@ymao1 ymao1 merged commit eb0deac into elastic:master May 24, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 24, 2021
* Updating readme

* Updating readme

* Fix plugin list docs
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request May 24, 2021
* Updating readme

* Updating readme

* Fix plugin list docs

Co-authored-by: ymao1 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Alerting release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants