Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing schema descriptions #100454

Merged
merged 2 commits into from
May 24, 2021
Merged

Add missing schema descriptions #100454

merged 2 commits into from
May 24, 2021

Conversation

pjhampton
Copy link
Contributor

Summary

Adds remaining missing descriptions for the security telemetry schema.
Related: #100387

Checklist

This PR does not alter Kibana's runtime.

For maintainers

@pjhampton pjhampton added Feature:Telemetry v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed v7.13.1 labels May 24, 2021
@pjhampton pjhampton self-assigned this May 24, 2021
@pjhampton pjhampton requested review from a team as code owners May 24, 2021 11:09
@pjhampton pjhampton enabled auto-merge (squash) May 24, 2021 11:10
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 22 20 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 261 149 -112
lens 67 45 -22
licensing 18 15 -3
maps 286 208 -78
ml 121 115 -6
monitoring 109 56 -53
stackAlerts 101 95 -6
total -295

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @pjhampton

afharo
afharo approved these changes May 24, 2021
View reviewed changes
Copy link
Member

@afharo afharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧡

FrankHassanabad
FrankHassanabad approved these changes May 24, 2021
View reviewed changes
Copy link
Contributor

@FrankHassanabad FrankHassanabad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pjhampton pjhampton merged commit bb6c2ef into master May 24, 2021
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 24, 2021
@pjhampton @kibanamachine
Add remaining descriptions to security usage telemetry schema. (elast…
9b8181a 
…ic#100454)
@kibanamachine kibanamachine mentioned this pull request May 24, 2021
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 24, 2021
@pjhampton @kibanamachine
Add remaining descriptions to security usage telemetry schema. (elast…
16f91cd 
…ic#100454)
@kibanamachine kibanamachine mentioned this pull request May 24, 2021
Merged
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
✅ 7.13
✅ 7.x

The backport PRs will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request May 24, 2021
@kibanamachine @pjhampton
Add remaining descriptions to security usage telemetry schema. (#100454…
1385c70 
…) (#100473)

Co-authored-by: Pete Hampton <[email protected]>
kibanamachine added a commit that referenced this pull request May 25, 2021
@kibanamachine @pjhampton
Add remaining descriptions to security usage telemetry schema. (#100454…
a223fe7 
…) (#100472)

Co-authored-by: Pete Hampton <[email protected]>
yctercero pushed a commit to yctercero/kibana that referenced this pull request May 25, 2021
@pjhampton @yctercero
Add remaining descriptions to security usage telemetry schema. (elast…
82d4607 
…ic#100454)
@spalger spalger deleted the pjhampton/secsol-add-additional-descriptions branch May 8, 2022 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afharo afharo afharo approved these changes

@FrankHassanabad FrankHassanabad FrankHassanabad approved these changes

Assignees

@pjhampton pjhampton

Labels
auto-backport Deprecated - use backport:version if exact versions are needed Feature:Telemetry release_note:skip Skip the PR/issue when compiling release notes v7.13.1 v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pjhampton @kibanamachine @FrankHassanabad @afharo