chore(NA): correctly setup dep order on js_library to fix windows build #100420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistic
added
auto-backport
|
Pinging @elastic/kibana-operations (Team:Operations) |
jbudz
approved these changes
May 20, 2021
|
I'll merge this as soon as the build got green without waiting for the code owners approval. Those changes are minimal and unblock our builds on Windows. |
💚 Build SucceededMetrics [docs]
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 20, 2021
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
May 21, 2021
…ld (#100420) (#100428) Co-authored-by: Tiago Costa <[email protected]>
yctercero
pushed a commit
to yctercero/kibana
that referenced
this pull request
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One step forward on #69706
That PR correctly defines the inter dependency order on the
js_libraryrules to fix the Bazel windows builds.