Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TSVB] Update TSVB sample viz with the default timerange mode #100376

Merged
merged 1 commit into from
May 20, 2021

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented May 20, 2021

Summary

Closes #99622
On 7.13 we changed the default value of the Data timerange mode from Last value to Entire timerange. The sample viz though still use the last value mode. This PR updates the TSVB visualizations to use the entire timerange

@stratoula stratoula added Feature:TSVB TSVB (Time Series Visual Builder) release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v8.0.0 labels May 20, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 22 20 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 261 149 -112
lens 67 45 -22
licensing 18 15 -3
maps 286 208 -78
ml 121 115 -6
monitoring 109 56 -53
stackAlerts 101 95 -6
total -295

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@stratoula stratoula marked this pull request as ready for review May 20, 2021 09:01
@stratoula stratoula requested a review from a team as a code owner May 20, 2021 09:01
@stratoula stratoula added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label May 20, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

Copy link
Contributor

@wylieconlon wylieconlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change LGTM, you've just added time_range_mode: entire_time_range

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:TSVB TSVB (Time Series Visual Builder) release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TSVB] Update the Data timerange mode setting to the default value for our sample viz
5 participants