Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Ban use of lodash.template (#100277) #100332

Merged
merged 3 commits into from
May 21, 2021

Conversation

kibanamachine
Copy link
Contributor

Backports the following commits to 7.x:

@legrego
Copy link
Member

legrego commented May 21, 2021

@elasticmachine merge upstream

@spalger
Copy link
Contributor

spalger commented May 21, 2021

@elasticmachine merge upstream

@kibanamachine
Copy link
Contributor Author

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
infra 1133 967 -166
observability 416 280 -136
osquery 287 151 -136
securitySolution 2209 2207 -2
uptime 741 612 -129
total -569

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
infra 1.9MB 1.8MB -135.6KB
observability 578.3KB 457.7KB -120.6KB
osquery 941.3KB 810.5KB -130.8KB
securitySolution 6.9MB 6.9MB -1.0KB
uptime 1.2MB 1.1MB -126.9KB
total -514.9KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
observability 33.7KB 33.7KB -40.0B
osquery 13.4KB 13.4KB -4.0B
total -44.0B
Unknown metric groups

References to deprecated APIs

id before after diff
canvas 29 25 -4
crossClusterReplication 8 6 -2
fleet 22 20 -2
globalSearch 4 2 -2
indexManagement 12 7 -5
infra 261 149 -112
lens 67 45 -22
licensing 18 15 -3
maps 286 208 -78
ml 121 115 -6
monitoring 109 56 -53
stackAlerts 101 95 -6
total -295

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @legrego

@kibanamachine kibanamachine merged commit 0f5a32c into elastic:7.x May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants