Upgrade accept 3.0.2 and @hapi/accept 5.0.1 to @hapi/accept 5.0.2 #100294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watson
added
v8.0.0
release_note:skip
💚 Build SucceededMetrics [docs]Unknown metric groupsReferences to deprecated APIs
History
To update your PR or re-run it, just comment with: cc @watson |
mshustov
approved these changes
May 19, 2021
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
May 19, 2021
💚 Backport successful
This backport PR will be merged automatically after passing CI. |
kibanamachine
added a commit
that referenced
this pull request
May 19, 2021
…00294) (#100313) Co-authored-by: Thomas Watson <[email protected]>
yctercero
pushed a commit
to yctercero/kibana
that referenced
this pull request
May 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm in the processes of getting rid of the remainder of the non-
@hapi-namespaced packages.First I thought to just upgrade to v3.2.4 as the namespace was added within the same major, so no breaking changes (besides the rename) would be included. But the only breaking changes included in v4.0.0 and v5.0.0 are as far as I can see the dropped support for older Node.js versions which we are not affected by. So we should be ok with using the latest version (which also includes types, so we can get rid of the
@types/package as well).