Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solutions] Replaces most deprecated io-ts alerting and list types #100234

Merged

Conversation

FrankHassanabad
Copy link
Contributor

@FrankHassanabad FrankHassanabad commented May 17, 2021

Summary

Replaces most of the deprecated io-ts alerting and list types within securitysolution as part of Phase 3 of 4 phases outlined in earlier PR's such as #99260

Checklist

@FrankHassanabad FrankHassanabad self-assigned this May 17, 2021
@FrankHassanabad FrankHassanabad changed the title Replaced most deprecated code [Security Solutions] Replaces most deprecated io-ts alerting and list types May 17, 2021
@FrankHassanabad FrankHassanabad added v8.0.0 v7.14.0 auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes and removed auto-backport Deprecated - use backport:version if exact versions are needed labels May 18, 2021
@FrankHassanabad FrankHassanabad requested a review from spong May 18, 2021 00:43
Copy link
Contributor

@yctercero yctercero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Exciting seeing the different phases trim down so much of our repeated code!

@FrankHassanabad FrankHassanabad marked this pull request as ready for review May 18, 2021 01:37
@FrankHassanabad FrankHassanabad requested review from a team as code owners May 18, 2021 01:37
@FrankHassanabad FrankHassanabad added the auto-backport Deprecated - use backport:version if exact versions are needed label May 18, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
lists 195 194 -1
securitySolution 2116 2106 -10
total -11

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
lists 210 207 -3
securitySolution 50 32 -18
total -21

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lists 55.2KB 55.2KB -21.0B
securitySolution 6.7MB 6.8MB +89.3KB
total +89.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
lists 190.1KB 188.8KB -1.3KB
securitySolution 159.7KB 61.1KB -98.5KB
total -99.9KB
Unknown metric groups

API count

id before after diff
lists 232 229 -3
securitySolution 59 32 -27
total -30

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @FrankHassanabad

@FrankHassanabad FrankHassanabad merged commit e15b887 into elastic:master May 18, 2021
@FrankHassanabad FrankHassanabad deleted the remove-deprecated-alerting-types branch May 18, 2021 05:28
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request May 18, 2021
… types (elastic#100234)

## Summary

Replaces most of the deprecated io-ts alerting and list types within securitysolution as part of Phase 3 of 4 phases outlined in earlier PR's such as elastic#99260

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
@kibanamachine
Copy link
Contributor

💚 Backport successful

Status Branch Result
7.x

This backport PR will be merged automatically after passing CI.

kibanamachine added a commit that referenced this pull request May 18, 2021
… types (#100234) (#100246)

## Summary

Replaces most of the deprecated io-ts alerting and list types within securitysolution as part of Phase 3 of 4 phases outlined in earlier PR's such as #99260

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios

Co-authored-by: Frank Hassanabad <[email protected]>
yctercero pushed a commit to yctercero/kibana that referenced this pull request May 25, 2021
… types (elastic#100234)

## Summary

Replaces most of the deprecated io-ts alerting and list types within securitysolution as part of Phase 3 of 4 phases outlined in earlier PR's such as elastic#99260

### Checklist

- [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Deprecated - use backport:version if exact versions are needed release_note:skip Skip the PR/issue when compiling release notes v7.14.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants