-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reporting] Switch Mac Chromium to the internally-hosted custom build #100165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsullivan
added
(Deprecated) Feature:Reporting
Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead
release_note:skip
Skip the PR/issue when compiling release notes
Team:AppServices
v7.13.0
labels
May 14, 2021
Pinging @elastic/kibana-app-services (Team:AppServices) |
tsullivan
changed the title
[Reporting] Switch Mac chromium to using an internally-hosted custom build of headless_shell
[Reporting] Switch Mac chromium to the internally-hosted custom build
May 14, 2021
tsullivan
changed the title
[Reporting] Switch Mac chromium to the internally-hosted custom build
[Reporting] Switch Mac Chromium to the internally-hosted custom build
May 14, 2021
@elasticmachine merge upstream |
mattkime
approved these changes
May 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was able to create PDF and PNG reports as expected, changes look good to me
💚 Build SucceededMetrics [docs]
History
To update your PR or re-run it, just comment with: |
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
May 17, 2021
…elastic#100165) * switch mac chromium download location to kibana team gcs * oops, fix the path to the binary Co-authored-by: Kibana Machine <[email protected]>
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
May 17, 2021
…elastic#100165) * switch mac chromium download location to kibana team gcs * oops, fix the path to the binary Co-authored-by: Kibana Machine <[email protected]>
tsullivan
added a commit
that referenced
this pull request
May 17, 2021
…#100165) (#100233) * switch mac chromium download location to kibana team gcs * oops, fix the path to the binary Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
tsullivan
added a commit
that referenced
this pull request
May 18, 2021
…#100165) (#100232) * switch mac chromium download location to kibana team gcs * oops, fix the path to the binary Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
yctercero
pushed a commit
to yctercero/kibana
that referenced
this pull request
May 25, 2021
…elastic#100165) (elastic#100232) * switch mac chromium download location to kibana team gcs * oops, fix the path to the binary Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
(Deprecated) Feature:Reporting
Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead
release_note:skip
Skip the PR/issue when compiling release notes
v7.13.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As of #98688, the Reporting team has decided to no longer bundle custom builds of Chromium's
headless_shell
for Mac and Windows. This presented an unforeseen change for the Mac release cycle. Infra team signs and notarizes the Kibana build for Mac, to comply with Apple Gatekeeper requirements. Our signing scripts did not know how to handleChromium.app
bundled with Kibana.This PR switches Mac to bundle a custom
headless_shell
binary for Mac, which is built to be compatible with Puppeteer 8.0.0.Build log
Note about
vim chromium/src/headless/BUILD.gn
-- I had to edit this file to find a workaround for https://groups.google.com/a/chromium.org/g/chromium-dev/c/jYibDVPm5X0/m/lQ1yBL0wBAAJHow to test on Mac
Testing can be automated with the functional tests: