Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] Allow layers to be excluded from fit to data #100098

Merged
merged 11 commits into from
May 18, 2021
Merged

[Maps] Allow layers to be excluded from fit to data #100098

merged 11 commits into from
May 18, 2021

Conversation

thomasneirynck
Copy link
Contributor

@thomasneirynck thomasneirynck commented May 13, 2021 •
edited
Loading

Summary

Closes #87107

optoutfit

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@thomasneirynck thomasneirynck marked this pull request as ready for review May 17, 2021 21:51
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@thomasneirynck thomasneirynck requested a review from nreese May 17, 2021 21:51
nreese
nreese approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
code review

@thomasneirynck thomasneirynck changed the title [Maps] Allow layers to not be included for fitting [Maps] Allow layers to be excluded from fit to data May 18, 2021
@thomasneirynck thomasneirynck added the auto-backport Deprecated - use backport:version if exact versions are needed label May 18, 2021
@kibanamachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
maps 2.7MB 2.7MB +2.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@thomasneirynck thomasneirynck merged commit 85a515a into elastic:master May 18, 2021
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 20, 2021
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 100098 or prevent reminders by adding the backport:skip label.

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create backports run node scripts/backport --pr 100098 or prevent reminders by adding the backport:skip label.

@thomasneirynck thomasneirynck mentioned this pull request May 24, 2021
Merged
thomasneirynck added a commit to thomasneirynck/kibana that referenced this pull request May 24, 2021
@thomasneirynck
[Maps] Allow layers to be excluded from fit to data (elastic#100098)
a80a1bf
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label May 24, 2021
thomasneirynck added a commit that referenced this pull request May 24, 2021
@thomasneirynck
[Maps] Allow layers to be excluded from fit to data (#100098) (#100459)
02c4133
yctercero pushed a commit to yctercero/kibana that referenced this pull request May 25, 2021
@thomasneirynck @yctercero
[Maps] Allow layers to be excluded from fit to data (elastic#100098)
93c2b1b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gchaps gchaps gchaps left review comments

@nreese nreese nreese approved these changes

@kindsun kindsun Awaiting requested review from kindsun

@jsanz jsanz Awaiting requested review from jsanz

Assignees
No one assigned
Labels
auto-backport Deprecated - use backport:version if exact versions are needed [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:enhancement v7.14.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Maps] Ability to mark layer to be used (or not) for auto fit bounds function
5 participants
@thomasneirynck @elasticmachine @kibanamachine @nreese @gchaps