-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Timelion] Changes the version of removal message #100022
[Timelion] Changes the version of removal message #100022
Conversation
Pinging @elastic/kibana-app (Team:KibanaApp) |
@KOTungseth are you ok with the text? The change is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tweaked the wording a little bit, but otherwise, LGTM!
src/plugins/timelion/public/components/timelion_deprecation.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Kaarina Tungseth <[email protected]>
Co-authored-by: Kaarina Tungseth <[email protected]>
Co-authored-by: Kaarina Tungseth <[email protected]>
Co-authored-by: Kaarina Tungseth <[email protected]>
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Public APIs missing comments
Any counts in public APIs
Async chunks
Public APIs missing exports
Unknown metric groupsAPI count
References to deprecated APIs
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
copy changes look good to me.
* Change the version of timelion removal on our documentation and warnings * Remove translations in order to be revisited * Remove double * Update docs/user/dashboard/timelion.asciidoc Co-authored-by: Kaarina Tungseth <[email protected]> * Update src/plugins/timelion/public/components/timelion_deprecation.tsx Co-authored-by: Kaarina Tungseth <[email protected]> * Update src/plugins/timelion/server/deprecations.ts Co-authored-by: Kaarina Tungseth <[email protected]> * Update src/plugins/timelion/server/deprecations.ts Co-authored-by: Kaarina Tungseth <[email protected]> Co-authored-by: Kaarina Tungseth <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
* Change the version of timelion removal on our documentation and warnings * Remove translations in order to be revisited * Remove double * Update docs/user/dashboard/timelion.asciidoc Co-authored-by: Kaarina Tungseth <[email protected]> * Update src/plugins/timelion/public/components/timelion_deprecation.tsx Co-authored-by: Kaarina Tungseth <[email protected]> * Update src/plugins/timelion/server/deprecations.ts Co-authored-by: Kaarina Tungseth <[email protected]> * Update src/plugins/timelion/server/deprecations.ts Co-authored-by: Kaarina Tungseth <[email protected]> Co-authored-by: Kaarina Tungseth <[email protected]> Co-authored-by: Kibana Machine <[email protected]> Co-authored-by: Kaarina Tungseth <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
* Change the version of timelion removal on our documentation and warnings * Remove translations in order to be revisited * Remove double * Update docs/user/dashboard/timelion.asciidoc Co-authored-by: Kaarina Tungseth <[email protected]> * Update src/plugins/timelion/public/components/timelion_deprecation.tsx Co-authored-by: Kaarina Tungseth <[email protected]> * Update src/plugins/timelion/server/deprecations.ts Co-authored-by: Kaarina Tungseth <[email protected]> * Update src/plugins/timelion/server/deprecations.ts Co-authored-by: Kaarina Tungseth <[email protected]> Co-authored-by: Kaarina Tungseth <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
Summary
Part of https://github.com/elastic/kibana-team/issues/298
As we are going to remove the timelion app on 7.16 I changed the deprecation message on our callout and docs. I don't mention the exact minor but use the
latest 7.x minor
in case it changes.Ui message:


Server message:
Docs preview: https://kibana_100022.docs-preview.app.elstc.co/guide/en/kibana/master/timelion.html
Checklist
Delete any items that are not applicable to this PR.