-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Metrics UI] Replace date_histogram with date_range aggregation in threshold alert #100004
[Metrics UI] Replace date_histogram with date_range aggregation in threshold alert #100004
Conversation
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
💚 Build SucceededMetrics [docs]Unknown metric groupsReferences to deprecated APIs
History
To update your PR or re-run it, just comment with: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this and everything seems to work.
I created some alarms, with different aggregations (avg, rate, min, max), some with warning thresholds, and the alarms were triggered correctly.
Do you think there is something else that should be tested specifically? Otherwise, I think this can be approved.
@estermv That's probably good, I just get anxious about changes like these We can merge if you wanna approve |
Is having the rate agg still use date_histogram a temporary fix or do we need to find a non derivative value at some point? Could the rate agg still possibly cause the inaccuracy issue until then? |
I think the inaccuracy issue is exclusive to |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
@Zacqary I assume we just missed this by accident, which is no big deal -- let me know if you have questions/concerns or if you ran into any problems with the backport, though. |
…reshold alert (elastic#100004) * [Metrics UI] Replace date_histogram with date_range aggregation in threshold alert * Remove console.log * Fix rate aggregation and offset
…reshold alert (elastic#100004) * [Metrics UI] Replace date_histogram with date_range aggregation in threshold alert * Remove console.log * Fix rate aggregation and offset
Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync. |
…reshold alert (elastic#100004) * [Metrics UI] Replace date_histogram with date_range aggregation in threshold alert * Remove console.log * Fix rate aggregation and offset
Summary
Closes #100003
This switches Metric Threshold alerts from a
date_histogram
to adate_range
in order to aggregate their data. This is in line with how Index Threshold alerts aggregate their data, and fixes an accuracy issue with gaps in document indexing.It may also improve performance across all aggregation types.
Because this changes the way alerts evaluate, we should test this extensively to make sure it doesn't misfire existing alerts
Checklist