Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a search panel to a dashboard causes an error and clicking a visualization panel causes an error #9558

Closed
trevan opened this issue Dec 19, 2016 · 2 comments
Assignees

Comments

@trevan
Copy link
Contributor

trevan commented Dec 19, 2016

With master, if you add a search/discover visualization to a dashboard, you'll get an error about "$scope.state is undefined".

It looks to have been caused by #9335. Before #9335, the dashboard_panel (https://github.com/elastic/kibana/blob/master/src/core_plugins/kibana/public/dashboard/directives/dashboard_panel.js) inherited the $scope from the dashboard. This included the "state" property (https://github.com/elastic/kibana/pull/9335/files#diff-c4bb79fe61d32ddedfa58bcf760ea323L31 even mentions it in a comment). The search panel expects to be able to access the state property (https://github.com/elastic/kibana/blob/master/src/core_plugins/kibana/public/dashboard/components/panel/lib/search.js#L9) and it is no longer available.

@trevan trevan changed the title Adding a search visualization to a dashboard causes an error Adding a search panel to a dashboard causes an error and clicking a visualization panel causes an error Dec 19, 2016
@trevan
Copy link
Contributor Author

trevan commented Dec 19, 2016

I just realized that the visualization panel also expects the state. It even has a comment about how it is not loved (https://github.com/elastic/kibana/blob/master/src/core_plugins/kibana/public/dashboard/components/panel/lib/visualization.js#L11).

So if you click on a visualization, it won't add a filter. Instead it will throw an error.

@stacey-gammon
Copy link
Contributor

Dangit, I'm on it, thanks for digging into this.

stacey-gammon added a commit to stacey-gammon/kibana that referenced this issue Dec 19, 2016
There are some dependencies on it.

Fixes elastic#9558
stacey-gammon added a commit that referenced this issue Dec 20, 2016
There are some dependencies on it.

Fixes #9558
elastic-jasper added a commit that referenced this issue Dec 20, 2016
Backports PR #9559

**Commit 1:**
Pass dashboard state through isolate scope

There are some dependencies on it.

Fixes #9558

* Original sha: a058976
* Authored by Stacey Gammon <[email protected]> on 2016-12-19T18:42:46Z
stacey-gammon pushed a commit that referenced this issue Dec 20, 2016
Backports PR #9559

**Commit 1:**
Pass dashboard state through isolate scope

There are some dependencies on it.

Fixes #9558

* Original sha: a058976
* Authored by Stacey Gammon <[email protected]> on 2016-12-19T18:42:46Z
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants