Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing test: Jest Tests.x-pack/plugins/reporting/server/routes/diagnostic - POST /diagnose/browser cleans up process and subscribers #89369

Closed
kibanamachine opened this issue Jan 26, 2021 · 8 comments · Fixed by #118003
Closed

Failing test: Jest Tests.x-pack/plugins/reporting/server/routes/diagnostic - POST /diagnose/browser cleans up process and subscribers #89369

kibanamachine opened this issue Jan 26, 2021 · 8 comments · Fixed by #118003
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead failed-test A test failure on a tracked branch, potentially flaky-test impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort

Comments

@kibanamachine
Copy link
Contributor

kibanamachine commented Jan 26, 2021 •
edited
Loading

A test failed on a tracked branch

Error: thrown: "Exceeded timeout of 6000 ms for a test.
Use jest.setTimeout(newTimeout) to increase the timeout value, if this is a long-running test."
    at /dev/shm/workspace/parallel/6/kibana/x-pack/plugins/reporting/server/routes/diagnostic/browser.test.ts:228:3
    at _dispatchDescribe (/dev/shm/workspace/kibana/node_modules/jest-circus/build/index.js:67:26)
    at describe (/dev/shm/workspace/kibana/node_modules/jest-circus/build/index.js:30:5)
    at Object.<anonymous> (/dev/shm/workspace/parallel/6/kibana/x-pack/plugins/reporting/server/routes/diagnostic/browser.test.ts:25:1)
    at Runtime._execModule (/dev/shm/workspace/kibana/node_modules/jest-runtime/build/index.js:1299:24)
    at Runtime._loadModule (/dev/shm/workspace/kibana/node_modules/jest-runtime/build/index.js:898:12)
    at Runtime.requireModule (/dev/shm/workspace/kibana/node_modules/jest-runtime/build/index.js:746:10)
    at jestAdapter (/dev/shm/workspace/kibana/node_modules/jest-circus/build/legacy-code-todo-rewrite/jestAdapter.js:106:13)
    at processTicksAndRejections (internal/process/task_queues.js:93:5)
    at runTestInternal (/dev/shm/workspace/kibana/node_modules/jest-runner/build/runTest.js:380:16)
    at runTest (/dev/shm/workspace/kibana/node_modules/jest-runner/build/runTest.js:472:34)
    at Object.worker (/dev/shm/workspace/kibana/node_modules/jest-runner/build/testWorker.js:133:12)

First failure: Jenkins Build
@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Jan 26, 2021
@tsullivan tsullivan added (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead Team:AppServices labels Feb 24, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

This was referenced Mar 1, 2021
Closed
Closed
Closed
Closed
Closed
@tsullivan
Copy link
Member

Several x-pack/plugins/reporting/server/routes jest tests failed once on Jan 25, with a couple more on Jan 27 and 28.

These look more like an temporary issue rather than a valid failure, since the failures were each only logged once, and haven't failed again in the last 35 days. Also, the fact that they are all Jest tests is suspicious

This was referenced Mar 1, 2021
Closed
Closed
Closed
@kibanamachine kibanamachine reopened this Oct 19, 2021
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 7.x

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Oct 21, 2021
@kibanamachine
Copy link
Contributor Author

New failure: CI Build - master

@kibanamachine
Copy link
Contributor Author

New failure: CI Build - 7.16

spalger added a commit that referenced this issue Oct 28, 2021
@spalger
skip flaky suite (#89369)
acf0426
spalger added a commit that referenced this issue Oct 28, 2021
@spalger
skip flaky suite (#89369)
68be5c2 
(cherry picked from commit acf0426)
spalger added a commit that referenced this issue Oct 28, 2021
@spalger
skip flaky suite (#89369)
0312f6c 
(cherry picked from commit acf0426)
@spalger
Copy link
Contributor

spalger commented Oct 28, 2021

4 failures in the last 7 days across PRs, master, and 7.16. Sounds like this should probably not be a unit test, or more isolated to the unit under test.

image

Skipped

master/8.1: acf0426
8.0: 68be5c2
7.16: 0312f6c

academo pushed a commit to academo/kibana that referenced this issue Oct 28, 2021
@spalger
skip flaky suite (elastic#89369)
07a700f
@tsullivan
Copy link
Member

Reporting has Jest tests in server/routes which have known problems running slow. The team must decide if we should tackle the root cause of what makes these Jest tests slow or if we should replace these tests with API tests

@jloleysens jloleysens mentioned this issue Nov 9, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead failed-test A test failure on a tracked branch, potentially flaky-test impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Reporting] Fix browser diagnostic Jest test flakiness jloleysens/kibana
5 participants
@tsullivan @spalger @sophiec20 @elasticmachine @kibanamachine