Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Index Management][Index Templates] Template should not allow # in the name #81870

Closed
cuff-links opened this issue Oct 28, 2020 · 2 comments · Fixed by #195776
Closed

[Index Management][Index Templates] Template should not allow # in the name #81870

cuff-links opened this issue Oct 28, 2020 · 2 comments · Fixed by #195776
Assignees
@SoniaSanzV
Labels
bug Fixes for quality problems that affect the customer experience Feature:Index Management Index and index templates UI good first issue low hanging fruit Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@cuff-links
Copy link
Contributor

cuff-links commented Oct 28, 2020 •
edited
Loading

Kibana Version

7.10 BC4

Elasticsearch Version

7.10 BC4

Browser

All

Steps to reproduce

  1. Go to Navigation Drawer > Stack Management > Index Templates
  2. Create a new template
  3. In the policy name, add a #.

Expected Behavior

You should not be able to put a # in the name. You should get an error stopping you from moving to the next step.

Actual Behavior

You are allowed to go on and create the template and you get the error at the review step after hitting save.
@cuff-links cuff-links added bug Fixes for quality problems that affect the customer experience Feature:Index Management Index and index templates UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Oct 28, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@sebelga sebelga added the good first issue low hanging fruit label Apr 26, 2021
@alisonelizabeth alisonelizabeth removed the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label Sep 17, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Sep 17, 2024
@alisonelizabeth alisonelizabeth added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more and removed Feature:Index Management Index and index templates UI needs-team Issues missing a team label labels Sep 17, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@alisonelizabeth alisonelizabeth added the Feature:Index Management Index and index templates UI label Sep 18, 2024
@SoniaSanzV SoniaSanzV mentioned this issue Oct 10, 2024
Merged
SoniaSanzV added a commit to SoniaSanzV/kibana that referenced this issue Oct 10, 2024
@SoniaSanzV
Merge branch 'main' into elastic#81870
8506730
SoniaSanzV added a commit to SoniaSanzV/kibana that referenced this issue Oct 10, 2024
@SoniaSanzV
Merge branch 'main' into elastic#81870
be15c58
SoniaSanzV added a commit to SoniaSanzV/kibana that referenced this issue Oct 11, 2024
@SoniaSanzV
Merge branch 'main' into elastic#81870
a28a974
SoniaSanzV added a commit to SoniaSanzV/kibana that referenced this issue Oct 15, 2024
@SoniaSanzV
Merge branch 'main' into elastic#81870
f6f1c44
SoniaSanzV added a commit to SoniaSanzV/kibana that referenced this issue Oct 15, 2024
@SoniaSanzV
Merge branch 'main' into elastic#81870
b8e054d
SoniaSanzV added a commit to SoniaSanzV/kibana that referenced this issue Oct 16, 2024
@SoniaSanzV
Merge branch 'main' into elastic#81870
a0ec972
SoniaSanzV added a commit that referenced this issue Oct 16, 2024
@SoniaSanzV
Not allow # in index template name (#195776)
4339f84 
Closes [#81870](#81870)

## Summary

When creating a new Template, it did not prevent entering a #, but when
saving the template the user received an error. The hash has been added
to the list of invalid characters for the name.


https://github.com/user-attachments/assets/2b59d245-c96f-4215-ad89-a3201bef5e94
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 16, 2024
@SoniaSanzV
Not allow # in index template name (elastic#195776)
96112d4 
Closes [elastic#81870](elastic#81870)

## Summary

When creating a new Template, it did not prevent entering a #, but when
saving the template the user received an error. The hash has been added
to the list of invalid characters for the name.

https://github.com/user-attachments/assets/2b59d245-c96f-4215-ad89-a3201bef5e94
(cherry picked from commit 4339f84)
kibanamachine added a commit that referenced this issue Oct 16, 2024
@kibanamachine @SoniaSanzV
[8.x] Not allow # in index template name (#195776) (#196485)
e061949 
# Backport

This will backport the following commits from `main` to `8.x`:
- [Not allow # in index template name
(#195776)](#195776)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Sonia Sanz
Vivas","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-16T07:16:36Z","message":"Not
allow # in index template name (#195776)\n\nCloses
[#81870](https://github.com/elastic/kibana/issues/81870)\r\n\r\n##
Summary\r\n\r\nWhen creating a new Template, it did not prevent entering
a #, but when\r\nsaving the template the user received an error. The
hash has been added\r\nto the list of invalid characters for the
name.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/2b59d245-c96f-4215-ad89-a3201bef5e94","sha":"4339f8465720c507351a2e65a6fe881a10dcd938","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Index
Management","Team:Kibana
Management","release_note:skip","v9.0.0","backport:prev-minor","v8.16.0"],"title":"Not
allow # in index template
name","number":195776,"url":"https://github.com/elastic/kibana/pull/195776","mergeCommit":{"message":"Not
allow # in index template name (#195776)\n\nCloses
[#81870](https://github.com/elastic/kibana/issues/81870)\r\n\r\n##
Summary\r\n\r\nWhen creating a new Template, it did not prevent entering
a #, but when\r\nsaving the template the user received an error. The
hash has been added\r\nto the list of invalid characters for the
name.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/2b59d245-c96f-4215-ad89-a3201bef5e94","sha":"4339f8465720c507351a2e65a6fe881a10dcd938"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/195776","number":195776,"mergeCommit":{"message":"Not
allow # in index template name (#195776)\n\nCloses
[#81870](https://github.com/elastic/kibana/issues/81870)\r\n\r\n##
Summary\r\n\r\nWhen creating a new Template, it did not prevent entering
a #, but when\r\nsaving the template the user received an error. The
hash has been added\r\nto the list of invalid characters for the
name.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/2b59d245-c96f-4215-ad89-a3201bef5e94","sha":"4339f8465720c507351a2e65a6fe881a10dcd938"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Sonia Sanz Vivas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SoniaSanzV SoniaSanzV

Labels
bug Fixes for quality problems that affect the customer experience Feature:Index Management Index and index templates UI good first issue low hanging fruit Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Not allow # in index template name SoniaSanzV/kibana
5 participants
@cuff-links @sebelga @alisonelizabeth @elasticmachine @SoniaSanzV