Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle half_float and scaled_float datatypes in Elasticsearch #7782

Closed
ycombinator opened this issue Jul 20, 2016 · 4 comments
Closed

Handle half_float and scaled_float datatypes in Elasticsearch #7782

ycombinator opened this issue Jul 20, 2016 · 4 comments

Comments

@ycombinator
Copy link
Contributor

Elasticsearch recently introduced half_float and scaled_float datatypes. This issue is to ensure that Kibana handles them properly.

Thanks @monicasarbu and @bohyun-e for drawing attention to these new datatypes.

@epixa
Copy link
Contributor

epixa commented Jul 20, 2016

To be clear, the issue seems to be that these types are treated as strings at the moment, but they should be treated as numbers instead.

@Bargs Bargs self-assigned this Jul 20, 2016
@Bargs
Copy link
Contributor

Bargs commented Jul 20, 2016

@ycombinator in addition to updating this in Kibana core, it looks like console maintains a list of types? Should I add half_float and scaled_float to the following list:

__one_of: ['text', 'keyword', 'float', 'double', 'byte', 'short', 'integer', 'long', 'date', 'boolean',

And is there anything else I need to do (I have no clue what that list is for, it just came up in a search :) )? I'm just asking you because it looks like you were the last one to touch it.

@ycombinator
Copy link
Contributor Author

@Bargs Yes, please add it to that line. You shouldn't need to do anything more other than testing that you can autocomplete those types while building out the body for a put mapping request.

@epixa
Copy link
Contributor

epixa commented Jul 21, 2016

Are there any similar changes that need to happen in x-pack?

Bargs added a commit to Bargs/kibana that referenced this issue Jul 22, 2016
Elasticsearch added a couple of new numeric datatypes, which means we
need to update our type casting list to include them. Kibana should
see them as "numbers" so they work properly in searches and aggs.

Fixes elastic#7782
Related elastic/elasticsearch#18887
Related elastic/elasticsearch#19264
Bargs added a commit to Bargs/kibana that referenced this issue Jul 26, 2016
Elasticsearch added a couple new data types, half_float and
scaled_float, so we should include those in Console's autocomplete
suggestions for mappings. Scaled_float also has a required parameter
called scaling_factor, which we suggest a sensible default for when
autocompleted. We talked about leaving the value empty, forcing the user
to pick a value, but the autocompleter doesn't seem to support blank
values.

Fixes: elastic#7811
Related: elastic#7782
airow pushed a commit to airow/kibana that referenced this issue Feb 16, 2017
Elasticsearch added a couple of new numeric datatypes, which means we
need to update our type casting list to include them. Kibana should
see them as "numbers" so they work properly in searches and aggs.

Fixes elastic#7782
Related elastic/elasticsearch#18887
Related elastic/elasticsearch#19264


Former-commit-id: 298ee35
airow pushed a commit to airow/kibana that referenced this issue Feb 16, 2017
Elasticsearch added a couple new data types, half_float and
scaled_float, so we should include those in Console's autocomplete
suggestions for mappings. Scaled_float also has a required parameter
called scaling_factor, which we suggest a sensible default for when
autocompleted. We talked about leaving the value empty, forcing the user
to pick a value, but the autocompleter doesn't seem to support blank
values.

Fixes: elastic#7811
Related: elastic#7782

Former-commit-id: a413b5c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants