-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle half_float and scaled_float datatypes in Elasticsearch #7782
Comments
To be clear, the issue seems to be that these types are treated as strings at the moment, but they should be treated as numbers instead. |
@ycombinator in addition to updating this in Kibana core, it looks like console maintains a list of types? Should I add
And is there anything else I need to do (I have no clue what that list is for, it just came up in a search :) )? I'm just asking you because it looks like you were the last one to touch it. |
@Bargs Yes, please add it to that line. You shouldn't need to do anything more other than testing that you can autocomplete those types while building out the body for a put mapping request. |
Are there any similar changes that need to happen in x-pack? |
Elasticsearch added a couple of new numeric datatypes, which means we need to update our type casting list to include them. Kibana should see them as "numbers" so they work properly in searches and aggs. Fixes elastic#7782 Related elastic/elasticsearch#18887 Related elastic/elasticsearch#19264
Elasticsearch added a couple new data types, half_float and scaled_float, so we should include those in Console's autocomplete suggestions for mappings. Scaled_float also has a required parameter called scaling_factor, which we suggest a sensible default for when autocompleted. We talked about leaving the value empty, forcing the user to pick a value, but the autocompleter doesn't seem to support blank values. Fixes: elastic#7811 Related: elastic#7782
Elasticsearch added a couple of new numeric datatypes, which means we need to update our type casting list to include them. Kibana should see them as "numbers" so they work properly in searches and aggs. Fixes elastic#7782 Related elastic/elasticsearch#18887 Related elastic/elasticsearch#19264 Former-commit-id: 298ee35
Elasticsearch added a couple new data types, half_float and scaled_float, so we should include those in Console's autocomplete suggestions for mappings. Scaled_float also has a required parameter called scaling_factor, which we suggest a sensible default for when autocompleted. We talked about leaving the value empty, forcing the user to pick a value, but the autocompleter doesn't seem to support blank values. Fixes: elastic#7811 Related: elastic#7782 Former-commit-id: a413b5c
Elasticsearch recently introduced
half_float
andscaled_float
datatypes. This issue is to ensure that Kibana handles them properly.Thanks @monicasarbu and @bohyun-e for drawing attention to these new datatypes.
The text was updated successfully, but these errors were encountered: