Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Dataframe Analytics: Update feature_influence format #77046

Closed
2 tasks done
walterra opened this issue Sep 9, 2020 · 3 comments
Closed
2 tasks done

[ML] Dataframe Analytics: Update feature_influence format #77046

walterra opened this issue Sep 9, 2020 · 3 comments
Assignees

Comments

@walterra
Copy link
Contributor

walterra commented Sep 9, 2020

Until now, the format for feature influence looked like this: Next to outlier_score there are feature_influence.<feature_name> entries.

This format is changing as having the feature name in the field name may become problematic (field explosion, invalid field chars, etc.)

The updated format will look like this:

{
  ...
  "results_field": {
    "outlier_score": 0.42,
    "feature_influence": [
      {
        "feature_name": "name1",
        "influence": 0.333
      },
      {
        "feature_name": "name2",
        "influence": 0.01
      }
    ]
  }
}

Since the feature is still experimental, we don't necessarily have to support the old format, still, it's worth discussing if we want to support it. We have to implement that the code recognizes a possible old format nonetheless, so we could just as well then support correctly showing the old data.

Elasticsearch related PR: elastic/elasticsearch#62068


@walterra walterra added :ml Feature:Data Frame Analytics ML data frame analytics features v7.10.0 labels Sep 9, 2020
@walterra walterra self-assigned this Sep 9, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@peteharverson
Copy link
Contributor

After the updates were made for the new feature_influence format, I think we should aim for:

  • new jobs display full results as currently, with color coded cells to indicte the influence of that feature
  • old jobs - results page opens without error, with table populated with data, but without the color coding of cells, plus a callout to indicate that the results are from a legacy format job

walterra added a commit that referenced this issue Oct 1, 2020
- Fixes cell color coding based on influence score for outlier detection results page data grid. (Part of #77046)
- Introduces expandable sections (<ExpandableSection />). In contrast to plain accordions, the main idea of this component is that it should also provide some sort of useful summary when collapsed instead of just being an expandable title. For example, the "Analysis" section is collapsed by default, but still offers information like analysis type, source and destination index. This concept should allow us to keep the analytics results pages usable with more content (additional results, evaluations, visualizations) being added over time.
- The "Analysis" section is a reuse of the expandable row from the analytics jobs list. Some design adjustments have been made to make it usable in both places.
walterra added a commit to walterra/kibana that referenced this issue Oct 1, 2020
- Fixes cell color coding based on influence score for outlier detection results page data grid. (Part of elastic#77046)
- Introduces expandable sections (<ExpandableSection />). In contrast to plain accordions, the main idea of this component is that it should also provide some sort of useful summary when collapsed instead of just being an expandable title. For example, the "Analysis" section is collapsed by default, but still offers information like analysis type, source and destination index. This concept should allow us to keep the analytics results pages usable with more content (additional results, evaluations, visualizations) being added over time.
- The "Analysis" section is a reuse of the expandable row from the analytics jobs list. Some design adjustments have been made to make it usable in both places.
walterra added a commit that referenced this issue Oct 2, 2020
…9188)

- Fixes cell color coding based on influence score for outlier detection results page data grid. (Part of #77046)
- Introduces expandable sections (<ExpandableSection />). In contrast to plain accordions, the main idea of this component is that it should also provide some sort of useful summary when collapsed instead of just being an expandable title. For example, the "Analysis" section is collapsed by default, but still offers information like analysis type, source and destination index. This concept should allow us to keep the analytics results pages usable with more content (additional results, evaluations, visualizations) being added over time.
- The "Analysis" section is a reuse of the expandable row from the analytics jobs list. Some design adjustments have been made to make it usable in both places.
@walterra
Copy link
Contributor Author

The callout for legacy feature influence format was added in #81123, closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants