Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visualize: Bad request when working with histogram aggregation #77023

Closed
flash1293 opened this issue Sep 9, 2020 · 6 comments · Fixed by #77684
Closed

Visualize: Bad request when working with histogram aggregation #77023

flash1293 opened this issue Sep 9, 2020 · 6 comments · Fixed by #77684
Assignees
@dej611
Labels
bug Fixes for quality problems that affect the customer experience Feature:Vis Editor Visualization editor issues Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

Kibana version: 7.10

Describe the bug:

When changing the settings for the histogram aggregation, it's possible to run into a state no interval is provided

Steps to reproduce:

  1. Create "histogram" aggregation on X axis
  2. Set "Max bars" to 5
  3. Apply
  4. Remove "Max bars" value to get back to "Auto"
  5. Apply
  6. "Bad request" error is shown

Expected behavior:
Should use default max bars
@flash1293 flash1293 added bug Fixes for quality problems that affect the customer experience Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Sep 9, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@timroes timroes added the Feature:Vis Editor Visualization editor issues label Sep 10, 2020
@timroes
Copy link
Contributor

timroes commented Sep 10, 2020

Most likely introduced via #76001

@dej611 dej611 self-assigned this Sep 10, 2020
alexwizp added a commit to alexwizp/kibana that referenced this issue Sep 16, 2020
@alexwizp
Visualize: Bad request when working with histogram aggregation
0fae836 
Closes: elastic#77023
@alexwizp
Copy link
Contributor

alexwizp commented Sep 16, 2020 •
edited
Loading

@timroes you are right, it's my regression. @dej611 I've created a draft PR (#77684) please review it. Looks like it solve that issue

@alexwizp alexwizp mentioned this issue Sep 16, 2020
Merged
7 tasks
@flash1293
Copy link
Contributor Author

@alexwizp I know @dej611 was working on this as well (he's also assigned to the issue). Can you two pair up on this?

@dej611 dej611 mentioned this issue Sep 17, 2020
Closed
1 task
@dej611
Copy link
Contributor

dej611 commented Sep 17, 2020

Yes, I pushed a fix this morning for it. I'm trying to write a unit test to stop regressions right now.

@alexwizp
Copy link
Contributor

alexwizp commented Sep 17, 2020 •
edited
Loading

@flash1293 @timroes @lukeelmers
I thought about a good test for this case, but I have doubts about the correctness of the algorithm for calculating the auto interval.

My main concern that for integer numbers it returns float intervals. It's super un-useful. In real example it looks like:
image

4b2ae64 in this commit algorithm for calculating was changed

@alexwizp alexwizp reopened this Sep 17, 2020
elasticmachine added a commit to alexwizp/kibana that referenced this issue Sep 17, 2020
@elasticmachine
Merge branch 'master' into elastic#77023
5fd3f40
alexwizp added a commit that referenced this issue Sep 18, 2020
@alexwizp @dej611 @elasticmachine
Visualize: Bad request when working with histogram aggregation (#77684)
89ef12e 
* Visualize: Bad request when working with histogram aggregation

Closes: #77023

* ✏️ Add some more fix context

* ✅ Add test

Co-authored-by: dej611 <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
alexwizp added a commit to alexwizp/kibana that referenced this issue Sep 18, 2020
@alexwizp @dej611 @elasticmachine
Visualize: Bad request when working with histogram aggregation (elast…
a021093 
…ic#77684)

* Visualize: Bad request when working with histogram aggregation

Closes: elastic#77023

* ✏️ Add some more fix context

* ✅ Add test

Co-authored-by: dej611 <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
alexwizp added a commit that referenced this issue Sep 18, 2020
@alexwizp @dej611 @elasticmachine
Visualize: Bad request when working with histogram aggregation (#77684)…
7e01905 
… (#77850)

* Visualize: Bad request when working with histogram aggregation

Closes: #77023

* ✏️ Add some more fix context

* ✅ Add test

Co-authored-by: dej611 <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: dej611 <[email protected]>
Co-authored-by: Elastic Machine <[email protected]>
@alexwizp alexwizp mentioned this issue Sep 21, 2020
Merged
7 tasks
@timroes timroes mentioned this issue Sep 21, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dej611 dej611

Labels
bug Fixes for quality problems that affect the customer experience Feature:Vis Editor Visualization editor issues Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Milestone
No milestone
5 participants
@timroes @dej611 @flash1293 @elasticmachine @alexwizp