Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing test: X-Pack Jest Tests.x-pack/plugins/task_manager/server/lib - Bulk Operation Buffer createBuffer() batch updates can be customised to execute after a certain period #72864

Closed
kibanamachine opened this issue Jul 22, 2020 · 7 comments · Fixed by #73024
Assignees
Labels
blocker failed-test A test failure on a tracked branch, potentially flaky-test skipped-test Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.10.0

Comments

@kibanamachine
Copy link
Contributor

A test failed on a tracked branch

Error: expect(jest.fn()).toHaveBeenCalledTimes(expected)

Expected number of calls: 2
Received number of calls: 1
    at setTimeout (/dev/shm/workspace/kibana/x-pack/plugins/task_manager/server/lib/bulk_operation_buffer.test.ts:83:32)
    at Timeout.callback [as _onTimeout] (/dev/shm/workspace/kibana/node_modules/jsdom/lib/jsdom/browser/Window.js:661:19)
    at ontimeout (timers.js:436:11)
    at tryOnTimeout (timers.js:300:5)
    at listOnTimeout (timers.js:263:5)
    at Timer.processTimers (timers.js:223:10)

First failure: Jenkins Build

@kibanamachine kibanamachine added the failed-test A test failure on a tracked branch, potentially flaky-test label Jul 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-test-triage (failed-test)

spalger added a commit that referenced this issue Jul 22, 2020
spalger added a commit that referenced this issue Jul 22, 2020
(cherry picked from commit 8305d9f)
@spalger
Copy link
Contributor

spalger commented Jul 22, 2020

14 Failures between PRs and master

image

Skipped

master: 8305d9f
7.x/7.10: 5ee3467

Attempted to skip this in 7.9 as well but the test is new as of 6378647#diff-7fe4566426f4487b3314a1020b6e0cba cc @gmmorris

@spalger spalger added blocker skipped-test Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.10.0 labels Jul 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@mikecote
Copy link
Contributor

Looks like usage of fake clocks will help with the flakiness.

@gmmorris
Copy link
Contributor

Sadly fake clocks don't seem to work with Rxjs operators... annoyingly.

I'm trying to find a better way of testing this...

@spalger
Copy link
Contributor

spalger commented Jul 23, 2020

Maybe you want to customize the Rxjs scheduler in the tests?

@gmmorris
Copy link
Contributor

I've simplified the tests... hoping that'll be enough 😬
If it isn't then I'll go down that route.

@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker failed-test A test failure on a tracked branch, potentially flaky-test skipped-test Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v7.10.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants