Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Remove timestamp from component template #71095

Closed
jonathan-buttner opened this issue Jul 8, 2020 · 4 comments · Fixed by #99619
Closed

[Fleet] Remove timestamp from component template #71095

jonathan-buttner opened this issue Jul 8, 2020 · 4 comments · Fixed by #99619
Assignees
@kpollich
Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project low hanging fruit DO NOT USE. Use `good first issue` instead Team:Endpoint Data Visibility Team managing the endpoint resolver Team:Fleet Team label for Observability Data Collection Fleet team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. technical debt Improvement of the software architecture and operational architecture

Comments

@jonathan-buttner
Copy link
Contributor

jonathan-buttner commented Jul 8, 2020 •
edited by jen-huang
Loading

ES fixed a bug here: elastic/elasticsearch#58956 that required us to include the timestamp field in component templates that defined a mapping section here:

kibana/x-pack/plugins/fleet/server/services/epm/elasticsearch/template/install.ts

Line 197 in 0b16688

mappingsTemplate = {

kibana/x-pack/test/fleet_api_integration/apis/epm/install_overrides.ts

Line 67 in 0b16688

expect(

This can now be removed as the bug is fixed.
@jonathan-buttner jonathan-buttner added Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Team:Endpoint Data Visibility Team managing the endpoint resolver Team:Fleet Team label for Observability Data Collection Fleet team Feature:Ingest Management labels Jul 8, 2020
@jonathan-buttner jonathan-buttner self-assigned this Jul 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Feature:EPM)

@elasticmachine
Copy link
Contributor

Pinging @elastic/endpoint-data-visibility-team (Team:Endpoint Data Visibility)

@ph ph added the technical debt Improvement of the software architecture and operational architecture label Oct 19, 2020
@MindyRS MindyRS added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Oct 27, 2020
@jen-huang jen-huang changed the title [EPM][Ingest Manager] Remove timestamp from component template [Fleet] Remove timestamp from component template Apr 27, 2021
@ph
Copy link
Contributor

ph commented Apr 28, 2021

@jen-huang I think this is in fleet no? This reference typescript code.

@jen-huang
Copy link
Contributor

@ph Oops, I assigned the wrong board yesterday :) Yes, this is Fleet.

@jen-huang jen-huang added the low hanging fruit DO NOT USE. Use `good first issue` instead label Apr 28, 2021
@kpollich kpollich self-assigned this May 10, 2021
kpollich added a commit to kpollich/kibana that referenced this issue May 10, 2021
@kpollich
Remove timestamp field from component template
92e422a 
Elasticsearch bug fixed upstream allows us to remove this field from the
template: elastic/elasticsearch/elastic#58956

Closes elastic#71095
@kpollich kpollich mentioned this issue May 10, 2021
Merged
kpollich added a commit that referenced this issue May 10, 2021
@kpollich
[Fleet] Remove timestamp field from component template (#99619)
baf11e8 
* Remove timestamp field from component template

Elasticsearch bug fixed upstream allows us to remove this field from the
template: elastic/elasticsearch/#58956

Closes #71095

* Remove timestamp field from functional test
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue May 10, 2021
@kpollich @kibanamachine
[Fleet] Remove timestamp field from component template (elastic#99619)
5c20625 
* Remove timestamp field from component template

Elasticsearch bug fixed upstream allows us to remove this field from the
template: elastic/elasticsearch/elastic#58956

Closes elastic#71095

* Remove timestamp field from functional test
kibanamachine added a commit that referenced this issue May 10, 2021
@kibanamachine @kpollich
[Fleet] Remove timestamp field from component template (#99619) (#99663)
fe4a949 
* Remove timestamp field from component template

Elasticsearch bug fixed upstream allows us to remove this field from the
template: elastic/elasticsearch/#58956

Closes #71095

* Remove timestamp field from functional test

Co-authored-by: Kyle Pollich <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kpollich kpollich

Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project low hanging fruit DO NOT USE. Use `good first issue` instead Team:Endpoint Data Visibility Team managing the endpoint resolver Team:Fleet Team label for Observability Data Collection Fleet team Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fleet] Remove timestamp field from component template kpollich/kibana
6 participants
@ph @jen-huang @MindyRS @kpollich @elasticmachine @jonathan-buttner