Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] Service map bug doesn't always display ML health indicators #68485

Closed
ogupte opened this issue Jun 8, 2020 · 1 comment · Fixed by #68486
Closed

[APM] Service map bug doesn't always display ML health indicators #68485

ogupte opened this issue Jun 8, 2020 · 1 comment · Fixed by #68486
Assignees
@ogupte
Labels
apm:service-maps Service Map feature in APM bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v7.8.0

Comments

@ogupte
Copy link
Contributor

ogupte commented Jun 8, 2020 •
edited
Loading

In APM service map, when no anomaly is found, the service popover will incorrectly prompt the user to create a new ML job for services which already have them set up. Expectation is that services with an ML job already created will inform the user of the running job. If no anomalies are detected, it should display with a gray border and still link to the anomaly explorer.
@ogupte ogupte added [zube]: In Progress bug Fixes for quality problems that affect the customer experience apm:service-maps Service Map feature in APM Team:APM All issues that need APM UI Team support labels Jun 8, 2020
@ogupte ogupte self-assigned this Jun 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

ogupte added a commit to ogupte/kibana that referenced this issue Jun 8, 2020
@ogupte
Closes elastic#68485 by:
acc3db6 
  - use the ML plugin to query for all APM jobs
  - inspect the ml job groups to find all jobs related to a particular service
  - use the mlAnomalySearch client to get ml job buckets with the max anomaly score
  - query for the model_plot buckets to obtain actual/median values for the ML description
  - return the relevant ML job with the max anomaly score for a service
  - indicate to the user that no anomalies were found for a service with an ml job
@ogupte ogupte mentioned this issue Jun 8, 2020
Merged
@rayafratkina rayafratkina added v7.8.0 and removed v7.8 labels Jun 9, 2020
ogupte added a commit that referenced this issue Jun 10, 2020
@ogupte @elasticmachine
[APM] Service maps - Fix missing ML status for services with jobs but…
cac9018 
… no anomalies (#68486)

* Closes #68485 by:
  - use the ML plugin to query for all APM jobs
  - inspect the ml job groups to find all jobs related to a particular service
  - use the mlAnomalySearch client to get ml job buckets with the max anomaly score
  - query for the model_plot buckets to obtain actual/median values for the ML description
  - return the relevant ML job with the max anomaly score for a service
  - indicate to the user that no anomalies were found for a service with an ml job

* - Use the anomalyDetectorsProvider jobs API rather than the search endpoint directly
- Defines a specific return type for the ml jobs api
- Update the empty anomaly data message

* Code and types cleanup

* Return to using record result type on anomaly queries. These are the
same values used in the anomaly explorer and it includes actual &
typical values which greatly improve performance of the previous query.

* - If anomaly data is missing show a gray border around node

* - moved AnomalyDetection out of service map Contents into own component

Co-authored-by: Elastic Machine <[email protected]>
ogupte added a commit to ogupte/kibana that referenced this issue Jun 10, 2020
@ogupte @elasticmachine
[APM] Service maps - Fix missing ML status for services with jobs but…
56a37be 
… no anomalies (elastic#68486)

* Closes elastic#68485 by:
  - use the ML plugin to query for all APM jobs
  - inspect the ml job groups to find all jobs related to a particular service
  - use the mlAnomalySearch client to get ml job buckets with the max anomaly score
  - query for the model_plot buckets to obtain actual/median values for the ML description
  - return the relevant ML job with the max anomaly score for a service
  - indicate to the user that no anomalies were found for a service with an ml job

* - Use the anomalyDetectorsProvider jobs API rather than the search endpoint directly
- Defines a specific return type for the ml jobs api
- Update the empty anomaly data message

* Code and types cleanup

* Return to using record result type on anomaly queries. These are the
same values used in the anomaly explorer and it includes actual &
typical values which greatly improve performance of the previous query.

* - If anomaly data is missing show a gray border around node

* - moved AnomalyDetection out of service map Contents into own component

Co-authored-by: Elastic Machine <[email protected]>
ogupte added a commit to ogupte/kibana that referenced this issue Jun 10, 2020
@ogupte
[APM] Service maps - Fix missing ML status for services with jobs but…
23f75d0 
… no anomalies (elastic#68486)

* Closes elastic#68485 by:
  - use the ML plugin to query for all APM jobs
  - inspect the ml job groups to find all jobs related to a particular service
  - use the mlAnomalySearch client to get ml job buckets with the max anomaly score
  - query for the model_plot buckets to obtain actual/median values for the ML description
  - return the relevant ML job with the max anomaly score for a service
  - indicate to the user that no anomalies were found for a service with an ml job

* - Use the anomalyDetectorsProvider jobs API rather than the search endpoint directly
- Defines a specific return type for the ml jobs api
- Update the empty anomaly data message

* Code and types cleanup

* Return to using record result type on anomaly queries. These are the
same values used in the anomaly explorer and it includes actual &
typical values which greatly improve performance of the previous query.

* - If anomaly data is missing show a gray border around node

* - moved AnomalyDetection out of service map Contents into own component

Co-authored-by: Elastic Machine <[email protected]>
# Conflicts:
#	x-pack/plugins/ml/server/shared.ts
ogupte added a commit that referenced this issue Jun 10, 2020
@ogupte @elasticmachine
[APM] Service maps - Fix missing ML status for services with jobs but…
8d212ea 
… no anomalies (#68486) (#68734)

* Closes #68485 by:
  - use the ML plugin to query for all APM jobs
  - inspect the ml job groups to find all jobs related to a particular service
  - use the mlAnomalySearch client to get ml job buckets with the max anomaly score
  - query for the model_plot buckets to obtain actual/median values for the ML description
  - return the relevant ML job with the max anomaly score for a service
  - indicate to the user that no anomalies were found for a service with an ml job

* - Use the anomalyDetectorsProvider jobs API rather than the search endpoint directly
- Defines a specific return type for the ml jobs api
- Update the empty anomaly data message

* Code and types cleanup

* Return to using record result type on anomaly queries. These are the
same values used in the anomaly explorer and it includes actual &
typical values which greatly improve performance of the previous query.

* - If anomaly data is missing show a gray border around node

* - moved AnomalyDetection out of service map Contents into own component

Co-authored-by: Elastic Machine <[email protected]>

Co-authored-by: Elastic Machine <[email protected]>
@ogupte ogupte mentioned this issue Jun 10, 2020
Closed
ogupte added a commit that referenced this issue Jun 10, 2020
@ogupte @elasticmachine
[7.8] [APM] Service maps - Fix missing ML status for services with jo…
2dc4c8b 
…bs but no anomalies (#68486) (#68735)

* [APM] Service maps - Fix missing ML status for services with jobs but no anomalies (#68486)

* Closes #68485 by:
  - use the ML plugin to query for all APM jobs
  - inspect the ml job groups to find all jobs related to a particular service
  - use the mlAnomalySearch client to get ml job buckets with the max anomaly score
  - query for the model_plot buckets to obtain actual/median values for the ML description
  - return the relevant ML job with the max anomaly score for a service
  - indicate to the user that no anomalies were found for a service with an ml job

* - Use the anomalyDetectorsProvider jobs API rather than the search endpoint directly
- Defines a specific return type for the ml jobs api
- Update the empty anomaly data message

* Code and types cleanup

* Return to using record result type on anomaly queries. These are the
same values used in the anomaly explorer and it includes actual &
typical values which greatly improve performance of the previous query.

* - If anomaly data is missing show a gray border around node

* - moved AnomalyDetection out of service map Contents into own component

Co-authored-by: Elastic Machine <[email protected]>
# Conflicts:
#	x-pack/plugins/ml/server/shared.ts

* - exposes ML types to be referenced in APM
- uses existing mlSearch API rather than the mlAnomalySearch API

Co-authored-by: Elastic Machine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ogupte ogupte

Labels
apm:service-maps Service Map feature in APM bug Fixes for quality problems that affect the customer experience Team:APM All issues that need APM UI Team support v7.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] Service maps - Fix missing ML status for services with jobs but no anomalies ogupte/kibana
4 participants
@sorenlouv @ogupte @elasticmachine @rayafratkina