Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kibana yml settings workaround in input control vis #67464

Closed
flash1293 opened this issue May 27, 2020 · 4 comments
Closed

Remove kibana yml settings workaround in input control vis #67464

flash1293 opened this issue May 27, 2020 · 4 comments
Labels
blocked Feature:Input Control Input controls visualization Feature:NP Migration Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@flash1293
Copy link
Contributor

In #63443 it was necessary to implement a workaround for passing some kibana.yml settings to the client using a new API route. This should be removed and replaced by the core exposeToBrowser functionality. This depends on #66085

Locations in code:

@flash1293 flash1293 added Feature:Input Control Input controls visualization Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:NP Migration labels May 27, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@timroes timroes added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 7, 2020
@flash1293
Copy link
Contributor Author

cc @ThomThomson @lizozom

This might not be the right approach after all - soon there will be a specific API to fetch auto complete values, so we can just use that instead of using the search service in a hacky way.

@lizozom
Copy link
Contributor

lizozom commented Nov 4, 2020

The API data.autocomplete.getValueSuggestions already exists.
If #81515 gets merged, it will also support the useTimeFilter option, which you need to support the existing API.

@Heenawter
Copy link
Contributor

I think it's fair to close this issue - we don't plan on changing anything on the legacy input controls, and all hacky code will get completely removed once we can finally remove them for good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked Feature:Input Control Input controls visualization Feature:NP Migration Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

5 participants