-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Breaking] [data.autocomplete] - Migrate core kibana autocomplete configs to data plugin #66085
Comments
Pinging @elastic/kibana-app-arch (Team:AppArch) |
Pinging @elastic/es-ui (Team:Elasticsearch UI) |
Hi @lukeelmers! In terms of how the Upgrade Assistant can help here, I think we could check for the existence of the deprecated settings and provide a code snippet with the replacement names. WDYT? We also now have a 8.0 breaking change issue template that might be helpful to take a look at to provide additional context. |
Thanks @alisonelizabeth! Yep I think a check like that would be just fine. We might have some other config names we are changing too, I'm taking a look at that and will let you know if there are any more to add. |
I'm going to remove the |
Pinging @elastic/kibana-app-services (Team:AppServices) |
Per the discussion in #46705, we need to migrate some of the yml config options which were previously part of the
kibana
plugin intodata
, where it makes more sense for them to live.kibana.autocompleteTimeout
->data.autocompleteTimeout
kibana.autocompleteTerminateAfter
->data.autocompleteTerminateAfter
Note that the long term plan is to rename everything to snake_case (as discussed in #7444, this is something we would do all at once instead of incrementally). But for now we should rename to camelCase, and address conversion to snake case whenever that larger PR is put together.
The text was updated successfully, but these errors were encountered: