-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Alerting] action validators should be passed allow-list config utils #64659
Labels
estimate:small
Small Estimated Level of Effort
Feature:Actions/Framework
Issues related to the Actions Framework
Feature:Actions
Team:ResponseOps
Label for the ResponseOps team (formerly the Cases and Alerting teams)
technical debt
Improvement of the software architecture and operational architecture
Comments
pmuellr
added
Feature:Alerting
Team:ResponseOps
Label for the ResponseOps team (formerly the Cases and Alerting teams)
labels
Apr 28, 2020
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
This was referenced Apr 28, 2020
pmuellr
added a commit
to pmuellr/kibana
that referenced
this issue
May 9, 2020
resolves elastic#64659 Previously, for action validators that needed to perform whitelisting checks, they would need to curry in the config utilties providing the whitelisting functions, into their validators. This is unwieldy - the config utilities should be passed explicitly in.
3 tasks
pmuellr
added a commit
to pmuellr/kibana
that referenced
this issue
May 26, 2020
elastic#64659 In this PR, the action whitelisting utilities have been refactored to allow them to (eventually) be used in plugins other than the actions plugin. Prior to this, actions required deeper integration with the internal of the actions plugin. This also adds some generic typing to the actionType config, secrets, and params properties, since they are now referred to in multiple places within the actionType.
mikecote
changed the title
[Alerting] action validators should be passed whitelist config utils
[Alerting] action validators should be passed allow-list config utils
Feb 10, 2021
At this point, the scope has moved beyond the allow list. It should also take into account the proxy and http/https agent in general, and probably the axios utilities. |
YulNaumenko
added
the
technical debt
Improvement of the software architecture and operational architecture
label
Mar 11, 2021
gmmorris
added
Feature:Actions
Feature:Actions/Framework
Issues related to the Actions Framework
and removed
Feature:Alerting
labels
Jul 1, 2021
doakalexi
moved this from Todo
to In Progress
in AppEx: ResponseOps - Execution & Connectors
Aug 22, 2022
1 task
doakalexi
moved this from In Progress
to In Review
in AppEx: ResponseOps - Execution & Connectors
Aug 25, 2022
Repository owner
moved this from In Review
to Done
in AppEx: ResponseOps - Execution & Connectors
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
estimate:small
Small Estimated Level of Effort
Feature:Actions/Framework
Issues related to the Actions Framework
Feature:Actions
Team:ResponseOps
Label for the ResponseOps team (formerly the Cases and Alerting teams)
technical debt
Improvement of the software architecture and operational architecture
While reviewing PR #63450, and thinking about moving the code that PR adds to the actions plugin to a case-specific plugin, it seems like we need to expose our whitelisting validating checks, which are currently private to the actions plugin.
Here's an example usage:
kibana/x-pack/plugins/actions/server/builtin_action_types/pagerduty.ts
Lines 121 to 135 in e09e6a2
See the code above that to see how
configObject
is curried onto the validator params.I think what we should probably do is add an optional
validatorServices
parameter object to all the validators - config, secrets, params (params not technically needed at this point, but might as well be consistent, and maybe needed in the future). Validators that need to whitelist will then just get the APIs needed to do the check in that object, without having to curry. Those that don't, won't need to change.The text was updated successfully, but these errors were encountered: