[ML] Kibana landing page shows file upload link for user without ML permissions

[pheyos]

Falls into same category as #21017

Found in version

• 7.7.0-bc5

Browser

• Chrome

Steps to reproduce

• Log into Kibana without any ML permissions

Expected result

• The Kibana landing page doesn't contain any links to ML

Actual result

• The ML app link is removed correctly, but the Import a CSV, NDJSON, or log file link is still there:
  

Additional information

• Following that link leads to a 404 page, which is the expected behavior with missing permissions

[elasticmachine]

Pinging @elastic/ml-ui (:ml)

[jgowdyelastic]

I believe this fix needs to happen in the EnvironmentService in the home plugin.
In the same way we register ML for the feature catalogue, we don't control whether the link should be shown.
Perhaps @flash1293 could have some input here?

[flash1293]

I looked into the issue and it looks like for now the home app should take care of this.

For the app links this filter takes care of removing the reference if the user is not allowed to access:

kibana/src/plugins/home/public/services/feature_catalogue/feature_catalogue_registry.ts

Line 76 in cba4f34

.filter(entry => capabilities.catalogue[entry.id] !== false)

For the environment this is not happening (but it could in the same way - check the capabilities and set ml to false if the current user is not allowed to access it):

kibana/src/plugins/home/public/application/components/home_app.js

Line 42 in cba4f34

const mlEnabled = environment.ml;

@elastic/kibana-core-ui Seems like a good first issue to get started with "Home" development - do you want to take over?

[ryankeairns]

@flash1293 we'll take a look at this for 7.7.1. During our weekly sync, @bmcconaghy noted some other longer term changes that we'd like to make here as well (e.g. turning this around so the plugin is doing the work to determine if the link should appear, etc.).

We're currently solely focused on the nav work, so this will likely not get touched for a couple of weeks. Let us know if that becomes a problem.

[ryankeairns]

Falls into the same category as #21017

[ryankeairns]

Addressed by new home page.