Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APM] destination.service fields to get service connections #60405

Closed
ogupte opened this issue Mar 17, 2020 · 0 comments · Fixed by #60908
Closed

[APM] destination.service fields to get service connections #60405

ogupte opened this issue Mar 17, 2020 · 0 comments · Fixed by #60908
Assignees
@dgieselaar
Labels
apm:service-maps Service Map feature in APM

Comments

@ogupte
Copy link
Contributor

ogupte commented Mar 17, 2020 •
edited by dgieselaar
Loading

As per elastic/apm#180, agents are expected to set fields: context.destination.service.resource, context.destination.service.name, context.destination.service.type when applicable. Service maps can make use of these fields to determine if 2 different spans are referring to the same logical service which might not be instrumented.

  • Change the composite aggregation to use span.destination.service.resource, service.name and service.environment
  • For external nodes, collapse by span.destination.service.resource
  • For internal nodes, collapse by service.name and service.environment
  • For collapsed external nodes, only show the first available values for span.type and span.subtype, alphabetically sorted
@ogupte ogupte added [zube]: Backlog apm:service-maps Service Map feature in APM labels Mar 17, 2020
@dgieselaar dgieselaar self-assigned this Mar 20, 2020
dgieselaar added a commit to dgieselaar/kibana that referenced this issue Mar 23, 2020
@dgieselaar
[APM] use span.destination.service.resource
cebc6e2 
Closes elastic#60405.
@dgieselaar dgieselaar mentioned this issue Mar 23, 2020
Merged
smith added a commit that referenced this issue Mar 23, 2020
@dgieselaar @smith
[APM] use span.destination.service.resource (#60908)
d5c13c0 
* [APM] use span.destination.service.resource

Closes #60405.

* update snapshots

Co-authored-by: Nathan L Smith <[email protected]>
dgieselaar added a commit to dgieselaar/kibana that referenced this issue Mar 23, 2020
@dgieselaar @smith
[APM] use span.destination.service.resource (elastic#60908)
7a82871 
* [APM] use span.destination.service.resource

Closes elastic#60405.

* update snapshots

Co-authored-by: Nathan L Smith <[email protected]>
dgieselaar added a commit that referenced this issue Mar 24, 2020
@dgieselaar @smith
[7.x] [APM] use span.destination.service.resource (#60908) (#61005)
908fb78 
* [APM] use span.destination.service.resource

Closes #60405.

* update snapshots

Co-authored-by: Nathan L Smith <[email protected]>

Co-authored-by: Nathan L Smith <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dgieselaar dgieselaar

Labels
apm:service-maps Service Map feature in APM
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[APM] use span.destination.service.resource dgieselaar/kibana
3 participants
@dgieselaar @ogupte @formgeist