-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failing test: Chrome X-Pack UI Functional Tests.x-pack/test/functional/apps/lens/lens_reporting·ts - lens app lens reporting should not cause PDF reports to fail #59229
Comments
Pinging @elastic/kibana-test-triage (failed-test) |
New failure: Jenkins Build |
New failure: Jenkins Build |
1 similar comment
New failure: Jenkins Build |
Pinging @elastic/kibana-app (Team:KibanaApp) |
Some log details;
|
Hi, the test is failing because the dashboard is rendering with a TypeError logged, and when Reporting sees that, it thinks the page has failed. See: kibana/x-pack/legacy/plugins/reporting/server/browsers/chromium/driver_factory/index.ts Line 224 in fa8da7c
If I ignore the
The
|
cc @jgowdyelastic who has worked on the ML licensing code #59275 |
It looks like this test is a real failure, not a flaky test. Master is currently broken. |
Fixed by #59365 |
New failure: Jenkins Build |
New failure: Jenkins Build |
New failure: Jenkins Build |
Pinging @elastic/kibana-reporting-services (Team:Reporting Services) |
New failure: Jenkins Build |
Failed because of "network changed" error:
Flaky since end of March across all branches >= 7.12: @spalger what's usually the cause of network changed problems? Seems like something bad is happening to the Kibana under test. |
The latest failure of this is another kind of error:
@tsullivan do you have an idea what could cause this? Not sure how we can stabilize reporting in this regard. |
|
The came up from a The error type is documented here: https://pptr.dev/#?product=Puppeteer&version=v5.4.1&show=api-event-pageerror I don't think Reporting should stop handling this type of error, or change it to simply log the error instead of fail the job when the error happens. Ideally, these kind of things would have better testing and be fixed before they can be surfaced by Reporting. |
Thanks for the context @tsullivan ! @elastic/kibana-alerting-services do you know why this error is showing up in the Lens reporting tests? Maybe this is an isolation problem and some of the Alerting test state is leaking into the Lens tests. |
@flash1293 I'm taking a look now. I'm investigating an idea as to why this may be happening. |
@flash1293 My theory didn't work out. The root place that would cause this error based on the logs you provided would be https://github.com/elastic/kibana/blob/master/x-pack/plugins/ml/public/plugin.ts#L185. But I wasn't able to make it throw the same error as shown. I tried different roles, licenses, SSL configurations, reports vs browser, etc. Can you point me where in CI you found those logs? I couldn't find it myself. |
@mikecote Sure, it happened on this PR for example: https://kibana-ci.elastic.co/job/elastic+kibana+pipeline-pull-request/121295/execution/node/711/log/ I'm going to the build stats cluster and search for |
@flash1293 thanks! I'm working on a PR as a first step that removes the throwing and replaces it with a console log instead: #98005. I still find it interesting how the alerting plugin gets into such a situation. |
@flash1293 I merged a fix so it doesn't throw unhandled exceptions (#98005). This should unblock or fix the flakiness here.. It will backport to 7.14. Let me know if it needs to go into 7.13 as well 🙏 |
@mikecote Thanks, that's great! I checked and it only failed on |
New failure: Jenkins Build |
@spalger The latest failure is caused by the dreaded network changed error again:
Is there any mitigation (except for migrating to buildkite)? I would love to somehow stabilize this test in the short term |
Closing for now as it failed because of |
A test failed on a tracked branch
First failure: Jenkins Build
The text was updated successfully, but these errors were encountered: