-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.0 only] [eventLog] make newly created and existing eventLog indices, hidden indices #58035
Comments
Pinging @elastic/kibana-alerting-services (Team:Alerting Services) |
Some examples how ML implemented the change:
|
Moving from |
See #93515. We may have to wait for 8.0, or we may be able to push to 8.x. |
Based on the comments (#93515 (comment)), it seems best to work on this issue in 8.0 so I will move it to |
Given that we have not been able to prioritise work for an event Log UI prior to 8.0, should we consider keeping these as hidden indices rather than system indices? Perhaps we can add some kind of deprecation notice on these indices that will allow us to switch them to system indices in 8.x? |
I don't think we want to change the event log to a system index - they are more constrained than hidden indices. And I'm worried, like Gidi, that since we're now using these indices for diagnostic purposes with users, we'll need to make sure they can still use these in ways we'd like them to be used. For example, you should be able to create a Kibana index pattern for the event log, and then create a Lens visualization using that index pattern. Make sure ILM still works, and what-not ... So, we'll likely need to do a little experimenting here, and ping ES folks more about hidden index caveats, etc. I still don't know of any reason why this would need to be done prior to 8.0. |
Sounds like we'll be able to defer this issue for higher priority items. Thanks for the input! |
I modified the issue's title. After talking with @kobelb, we will go with the approach of creating new indices as hidden in 8.0 or higher and leave existing indices (created in 7.x) as is. I believe the same should apply for aliases. Since they are created per-version, we should be ok to mark 8.0+ aliases as hidden as well. |
Reverting title back to new + existing indices after further discussion with @kobelb and @stacey-gammon for consistency. There isn't a strong push to migrate existing indices in 8.0, but it sounded fairly easy (single PUT HTTP request, probably in migration assistant) and might as well if it's easy. |
For a brand new event log index, we are able to set For existing event log indices, this is less straightforward. According to the docs, only the dynamic index settings can be updated after an index has been created. |
@kobelb, from #58035 (comment), I recall our prior conversation you mentioned we can "migrate" the existing event log indices to hidden via a single PUT HTTP request (via the upgrade assistant?). Do you have an example of how to do so? |
Very interesting... I did not read the documentation as closely as you did @ymao1, and I was able to use the ES APIs against 7.14 to change indices from non-hidden to hidden:
@elastic/es-data-management can you all confirm whether we should be able to update existing indices to be hidden? |
@kobelb That is interesting! I was using the ES Client through Kibana to update the settings and unable to have the updates show up, which is why I dug into the docs. It obviously works though, so I must have missed something. Thanks! |
Yeah, I wonder if it is different via the ES Client. I'm using
which sends
and the changes are not reflected in the index settings. I did try it via Dev Tools using the same command you did and that did work though, although the index still shows up when you do a |
@williamrandolph / @gwbrown - Can you assist with this question ? |
The I just tried it quickly (in a BC of 7.15.0, as that's what I had handy), and updating |
@ymao1 I'm pretty sure I know what's wrong: If that's the body of the settings update request, that request will error out 100% of the time. A number of settings there are static and cannot be updated via API, such as When I try to issue that command against a test cluster, I get a response like this:
When the update settings request errors out like this, none of the settings will be applied. Fortunately, I think this should be easy to solve: Just don't put the existing settings into the settings update request.
Is all that's required to update |
@gwbrown That makes so much sense. I was trying to make sure I didn't overwrite any existing settings but the API is smarter than that. Thank you! |
Following up, I've opened a PR to correct the docs for |
In elasticsearch >= 7.7, a new feature will be available to make indices "hidden". To some extent, it's just a formalism of the "dot-prefix" convention we use for Kibana-internal indices.
For more info on hidden indices, see: PR elastic/elasticsearch#50452
We should probably make the eventLog indices be hidden. Especially since we don't know if we could "change" eventLog from a "normal" index to a "hidden" index, if we first ship eventLog that writes to normal indices but want to switch later to hidden.
I don't think this needs to happen until we switch on eventLog writing to indices as default true - currently it's default false. No ES resources will be touched if it's false. Current thinking is that we'll switch to default true after the 7.7 freeze, or shortly thereafter, to get a long burn-in on it's use during 7.8 development.
The text was updated successfully, but these errors were encountered: