Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Logs / Metrics UI] [NP followup] Only use plugin start contracts in the UI #58014

Closed
Kerry350 opened this issue Feb 19, 2020 · 1 comment
Closed
Assignees
Labels
chore Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature loe:small Small Level of Effort Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services

Comments

@Kerry350
Copy link
Contributor

This discussion provides context for this ticket.

We should, once possible, move to only using ClientPluginsStart. And remove merging of setup and start. This, however, relies on the usageCollection plugin making reportUiStats available in start first.

@Kerry350 Kerry350 added Feature:Metrics UI Metrics UI feature Feature:Logs UI Logs UI feature Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services labels Feb 19, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui)

@Kerry350 Kerry350 added the loe:small Small Level of Effort label Jun 4, 2020
@jasonrhodes jasonrhodes self-assigned this Jun 25, 2020
jasonrhodes added a commit to jasonrhodes/kibana that referenced this issue Jun 29, 2020
jasonrhodes added a commit to jasonrhodes/kibana that referenced this issue Jun 30, 2020
…rview data fetchers (elastic#69999)

* Switches mount callbacks to only use start deps

Fixes elastic#58014

* Sets up skeleton logs data fetchers for overview

* Fixes type hacks for logs fetcher

* Prevent kibana from crashing on initial load

* Fixes types and linting errors

* Fixes some linting import/export issues

Co-authored-by: Alejandro Fernández Gómez <[email protected]>
jasonrhodes added a commit that referenced this issue Jun 30, 2020
…rview data fetchers (#69999) (#70351)

* Switches mount callbacks to only use start deps

Fixes #58014

* Sets up skeleton logs data fetchers for overview

* Fixes type hacks for logs fetcher

* Prevent kibana from crashing on initial load

* Fixes types and linting errors

* Fixes some linting import/export issues

Co-authored-by: Alejandro Fernández Gómez <[email protected]>

Co-authored-by: Alejandro Fernández Gómez <[email protected]>
Bamieh pushed a commit to Bamieh/kibana that referenced this issue Jul 1, 2020
…rview data fetchers (elastic#69999)

* Switches mount callbacks to only use start deps

Fixes elastic#58014

* Sets up skeleton logs data fetchers for overview

* Fixes type hacks for logs fetcher

* Prevent kibana from crashing on initial load

* Fixes types and linting errors

* Fixes some linting import/export issues

Co-authored-by: Alejandro Fernández Gómez <[email protected]>
@zube zube bot removed the [zube]: Done label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:Logs UI Logs UI feature Feature:Metrics UI Metrics UI feature loe:small Small Level of Effort Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services
Projects
None yet
Development

No branches or pull requests

4 participants