-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[APM] Documentation links using ElasticDocsLink.tsx don't always work #56453
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:NP Migration
Team:APM
All issues that need APM UI Team support
v7.7.0
Comments
bmorelli25
added
bug
Fixes for quality problems that affect the customer experience
Team:APM
All issues that need APM UI Team support
labels
Jan 30, 2020
Pinging @elastic/apm-ui (Team:apm) |
smith
added
[zube]: Backlog
Feature:New Platform
Feature:NP Migration
and removed
[zube]: In Progress
Feature:New Platform
labels
Mar 24, 2020
smith
added a commit
to smith/kibana
that referenced
this issue
Mar 30, 2020
Remove `packageInfo` (from ui/metadata package from the legacy platform) and replace with `core.dockLinks` in the `ElasticDocsLink` component. Fixes elastic#56453 Fixes elastic#60945
smith
added a commit
that referenced
this issue
Mar 30, 2020
smith
added a commit
to smith/kibana
that referenced
this issue
Mar 30, 2020
* Use docLinks API for APM doc links Remove `packageInfo` (from ui/metadata package from the legacy platform) and replace with `core.dockLinks` in the `ElasticDocsLink` component. Fixes elastic#56453 Fixes elastic#60945
smith
added a commit
to smith/kibana
that referenced
this issue
Mar 30, 2020
* Use docLinks API for APM doc links Remove `packageInfo` (from ui/metadata package from the legacy platform) and replace with `core.dockLinks` in the `ElasticDocsLink` component. Fixes elastic#56453 Fixes elastic#60945
smith
added a commit
that referenced
this issue
Mar 31, 2020
smith
added a commit
that referenced
this issue
Apr 2, 2020
* Use docLinks API for APM doc links Remove `packageInfo` (from ui/metadata package from the legacy platform) and replace with `core.dockLinks` in the `ElasticDocsLink` component. Fixes #56453 Fixes #60945 Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:NP Migration
Team:APM
All issues that need APM UI Team support
v7.7.0
The
ElasticDocsLink.tsx
component uses the version of Kibana to generate links to documentation.kibana/x-pack/legacy/plugins/apm/public/components/shared/Links/ElasticDocsLink.tsx
Lines 19 to 23 in 472e7fb
This is fine, except when running a version of Kibana like
8.0.0
, or7.6.0-snapshot
. Documentation for those versions don't exist, which breaks the links that use the component.As an example, when running
7.6.0-snapshot
: "How to add labels and other data" links tohttps://www.elastic.co/guide/en/apm/get-started/7.6.0-SNAPSHOT/metadata.html
instead ofhttps://www.elastic.co/guide/en/apm/get-started/7.6/metadata.html
.kibana/x-pack/legacy/plugins/apm/public/components/shared/MetadataTable/index.tsx
Lines 57 to 61 in 472e7fb
Is it possible for this component to use the
{config.docs.version}
that the links in the APM tutorial use? This method uses the correct documentation version for external links`. As an example:kibana/x-pack/plugins/apm/server/tutorial/index.ts
Line 84 in 472e7fb
The text was updated successfully, but these errors were encountered: