Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest] feature-ingest NP Migration #56452

Closed
77 of 78 tasks
jen-huang opened this issue Jan 30, 2020 · 1 comment
Closed
77 of 78 tasks

[Ingest] feature-ingest NP Migration #56452

jen-huang opened this issue Jan 30, 2020 · 1 comment
Assignees
@jen-huang
Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Feature:Fleet Fleet team's agent central management project Meta Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@jen-huang
Copy link
Contributor

jen-huang commented Jan 30, 2020 •
edited
Loading

feature-ingest NP Migration

Overview

In the feature-ingest feature branch today, we have 3 legacy x-pack plugins:

  • ingest
  • epm
  • fleet

Recently, we introduced a new plugin called ingest_manager to attempt to unify and fold these three plugins into one plugin: original PR. ingest_manager is a Kibana NP (new platform) plugin. This issue breaks down the remaining work needed to complete the migration work of the three legacy plugins into the new one.

Developer notes

  • What was previously known as policies has been renamed to agent configs, please update variable names during migration where needed.

ingest -> ingest_manager

  • Migrate x-pack settings
    • xpack.ingestManager.enabled
  • Migrate saved object mappings
    • agent_configs
    • datasources
    • outputs
  • Migrate model schemas and typings and add missing ones in /common
    • Agent configs
    • Datasources
    • Inputs
    • Outputs
  • Migrate server routes and services (aka libs)
    • Add request/response schemas & types for all routes to /common
    • Agent configs
    • Datasources
    • Outputs (service only, no routes)
  • Register feature + privileges
  • Tests
    • API integration tests
  • Remove x-pack/legacy/plugins/ingest
    • Mostly complete, a few static files with typinges remain due to epm and fleet imports, so complete removal is blocked until the other two are fully migrated

epm -> ingest_manager

  • Migrate x-pack settings
    • xpack.ingestManager.epm.enabled
    • xpack.ingestManager.epm.registryUrl
  • Migrate saved object mappings
    • packages
  • Migrate model schemas and typings and add missing ones in /common
    • Packages
    • Assets
    • [ ] Inputs/Outputs/Policy/Stream
      • Done as part of ingest migration
  • Migrate server routes and services (aka libs)
    • Add request/response schemas & types for all routes to /common
    • Packages
    • Registry
    • [ ] Datasources
      • Do not migrate, functionality will change
  • Migrate UI
    • Add useRequest/sendRequest wrappers for all API calls
    • Package list page (home/search)
    • Package details page
    • [ ] Add datasource form
      • Do not migrate, functionality will change
  • Remove x-pack/legacy/plugins/epm

fleet -> ingest_manager

  • Migrate x-pack settings
    • xpack.ingestManager.fleet.enabled
    • xpack.ingestManager.fleet.defaultOutputHost
  • Migrate registration of feature + privileges
  • Migrate saved object mappings
    • agents
    • agent_events
    • enrollment_api_keys
  • Migrate model schemas and typings and add missing ones in /common
    • Agents
    • Agent events
    • Enrollment api keys
  • Migrate server routes and services (aka libs)
    • Add request/response schemas & types for all routes to /common
    • Agents
    • Agent events
    • Agent configuration generation
    • Agent status
    • Access api keys
    • Enrollment api keys
    • Install scripts
    • Artifacts (?)
  • Migrate UI
    • Add useRequest/sendRequest wrappers for all API calls
    • Error pages
      • Security enforcement
      • License check
      • Permissions (access) check
    • Fleet setup form
    • Agent configs
      • List page
      • Details page
      • Create form
      • Edit form
      • Delete form
      • [ ] Assign/unassign datasources
        • Do not migrate, functionality will change
    • Agents
      • List page
      • Details page
      • Enrollment form
      • Unenrollment form
  • Remove x-pack/legacy/plugins/fleet
@jen-huang jen-huang added Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Feature:Fleet Fleet team's agent central management project labels Jan 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest (Feature:EPM)

@ph ph mentioned this issue Feb 4, 2020
Closed
5 tasks
@neptunian neptunian mentioned this issue Feb 5, 2020
Closed
@ph ph added the Meta label Feb 6, 2020
ph added a commit to ph/beats that referenced this issue Feb 12, 2020
@ph
Migration of Fleet -> ingest_manager affect the API paths
53b0693 
The migration of the Fleet into the ingest_manager plugin will
affect API path. This PR changed the existing routes to reflect that
change.

We need to synchronize the merge with elastic/kibana#56452
@jen-huang jen-huang self-assigned this Feb 13, 2020
@ph ph mentioned this issue Feb 13, 2020
Merged
5 tasks
ph added a commit to ph/beats that referenced this issue Feb 13, 2020
@ph
Migration of Fleet -> ingest_manager affect the API paths
3919c85 
The migration of the Fleet into the ingest_manager plugin will
affect API path. This PR changed the existing routes to reflect that
change.

We need to synchronize the merge with elastic/kibana#56452
ph added a commit to elastic/beats that referenced this issue Feb 13, 2020
@ph
Migration of Fleet -> ingest_manager affect the API paths (#16314)
32b4ef7 
The migration of the Fleet into the ingest_manager plugin will
affect API path. This PR changed the existing routes to reflect that
change.

We need to synchronize the merge with elastic/kibana#56452
@nchaulet nchaulet mentioned this issue Feb 14, 2020
Merged
@skh skh mentioned this issue Feb 14, 2020
Merged
This was referenced Feb 19, 2020
Merged
Closed
@jen-huang jen-huang added the Team:Fleet Team label for Observability Data Collection Fleet team label Mar 26, 2020
leweafan pushed a commit to leweafan/beats that referenced this issue Apr 28, 2023
@ph
Migration of Fleet -> ingest_manager affect the API paths (elastic#16314
39aef28 
)

The migration of the Fleet into the ingest_manager plugin will
affect API path. This PR changed the existing routes to reflect that
change.

We need to synchronize the merge with elastic/kibana#56452
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jen-huang jen-huang

Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Feature:Fleet Fleet team's agent central management project Meta Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ph @jen-huang @elasticmachine