Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server.xsrf.token in config file prevents startup #5635

Closed
rashidkpc opened this issue Dec 10, 2015 · 1 comment
Closed

server.xsrf.token in config file prevents startup #5635

rashidkpc opened this issue Dec 10, 2015 · 1 comment
Assignees
@jbudz
Labels
blocker bug Fixes for quality problems that affect the customer experience PR sent v4.2.2 v4.3.1 v4.3.2 v4.4.0

Comments

@rashidkpc
Copy link
Contributor

I know we removed this, but some users are still going to have it in there. It doesn't feel right to break the config file on a patch release, we should print a deprecation notice and remove the ability to start in 5.0
@rashidkpc rashidkpc added bug Fixes for quality problems that affect the customer experience blocker v4.4.0 v4.1.3 v4.3.1 v4.2.2 v4.1.4 and removed v4.1.3 labels Dec 10, 2015
@rashidkpc rashidkpc removed the v4.1.3 label Dec 10, 2015
@jbudz jbudz self-assigned this Dec 10, 2015
@epixa
Copy link
Contributor

epixa commented Dec 10, 2015

I dropped the 4.1.4 label because the 4.1 line doesn't include any of the kbn-version stuff, so the xsrf token stuff shouldn't be removed.

@epixa epixa removed the v4.1.4 label Dec 10, 2015
@jbudz jbudz mentioned this issue Dec 10, 2015
Closed
jbudz added a commit to jbudz/kibana that referenced this issue Dec 10, 2015
@jbudz
[config] Add server.xsrf.token as a deprecated config. Closes elastic…
a91c663 
…#5635.
@jbudz jbudz added the PR sent label Dec 11, 2015
@jbudz jbudz closed this as completed in 48dfcad Dec 11, 2015
jbudz added a commit that referenced this issue Dec 11, 2015
@jbudz
Add server.xsrf.token as a deprecated config. Closes #5635.
a956639 
Fixes #5641
jbudz added a commit that referenced this issue Dec 11, 2015
@jbudz
Add server.xsrf.token as a deprecated config. Closes #5635.
dd04ac6 
Fixes #5641
jbudz added a commit that referenced this issue Dec 11, 2015
@jbudz
Add server.xsrf.token as a deprecated config. Closes #5635.
282dd20 
Fixes #5641
jbudz added a commit that referenced this issue Dec 11, 2015
@jbudz
Add server.xsrf.token as a deprecated config. Closes #5635.
a06807f 
Fixes #5641
jbudz added a commit that referenced this issue Dec 11, 2015
@jbudz
Add server.xsrf.token as a deprecated config. Closes #5635.
d617fc6 
Fixes #5641
@rohprimardho rohprimardho mentioned this issue Dec 17, 2015
Closed
@epixa epixa added v4.3.3 and removed v4.3.2 labels Feb 11, 2016
@epixa epixa added the v4.3.2 label Mar 4, 2016
@epixa epixa removed the v4.3.3 label Mar 4, 2016
@snyk-bot snyk-bot mentioned this issue May 27, 2021
Open
@larrycameron80 larrycameron80 mentioned this issue Jan 10, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jbudz jbudz

Labels
blocker bug Fixes for quality problems that affect the customer experience PR sent v4.2.2 v4.3.1 v4.3.2 v4.4.0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@epixa @rashidkpc @jbudz