Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for Stream and Buffer payload in error responses #56305

Closed
mshustov opened this issue Jan 29, 2020 · 1 comment · Fixed by #188937
Closed

Add tests for Stream and Buffer payload in error responses #56305

mshustov opened this issue Jan 29, 2020 · 1 comment · Fixed by #188937
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@mshustov
Copy link
Contributor

mshustov commented Jan 29, 2020 •
edited
Loading

#55690 added Stream and Buffer as a valid error payload for error responses. we should add test covering this functionality
and extend ResponseError union type with Buffer | stream.Readable

Related discussion: #55690 (comment)
@mshustov mshustov added Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform labels Jan 29, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@mshustov mshustov mentioned this issue Jan 29, 2020
Merged
3 tasks
@pgayvallet pgayvallet mentioned this issue Jul 23, 2024
Merged
pgayvallet added a commit that referenced this issue Jul 24, 2024
@pgayvallet
Add FTR tests for stream/buffer error responses (#188937)
85a90a7 
## Summary

Fix #56305
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add FTR tests for stream/buffer error responses pgayvallet/kibana
2 participants
@mshustov @elasticmachine