Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

value suggestions server route -> data plugin #52842

Closed
2 tasks
lukeelmers opened this issue Dec 12, 2019 · 2 comments · Fixed by #53191
Closed
2 tasks

value suggestions server route -> data plugin #52842

lukeelmers opened this issue Dec 12, 2019 · 2 comments · Fixed by #53191
Assignees
@alexwizp
Labels
Feature:NP Migration

Comments

@lukeelmers
Copy link
Member

Part of #51560

The suggestionsProvider has already been moved to the new platform data plugin in src/plugins/data/public/suggestions_provider. There is also an api route that it depends on, which should be relocated as well:

  • Convert src/legacy/core_plugins/kibana/server/routes/api/suggestions to TS
  • Relocate to src/plugins/data/server
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@lukeelmers lukeelmers changed the title value suggestions -> data plugin value suggestions server route -> data plugin Dec 12, 2019
@lukeelmers lukeelmers mentioned this issue Dec 12, 2019
Closed
40 tasks
@lukeelmers
Copy link
Member Author

see also the notes in #50925

@lukeelmers lukeelmers mentioned this issue Dec 12, 2019
Closed
@alexwizp alexwizp mentioned this issue Dec 12, 2019
Closed
7 tasks
alexwizp added a commit to alexwizp/kibana that referenced this issue Dec 16, 2019
@alexwizp
value suggestions server route -> data plugin
819d3c0 
Closes  elastic#52842
@alexwizp alexwizp mentioned this issue Dec 16, 2019
Merged
7 tasks
alexwizp added a commit to alexwizp/kibana that referenced this issue Dec 17, 2019
@alexwizp
value suggestions server route -> data plugin
1fcf01e 
Closes elastic#52842
alexwizp added a commit that referenced this issue Dec 18, 2019
@alexwizp
value suggestions server route -> data plugin (#53191)
b1273e2 
* value suggestions server route -> data plugin

Closes #52842

* fix PR comments

* fix PR comments
alexwizp added a commit to alexwizp/kibana that referenced this issue Dec 18, 2019
@alexwizp
value suggestions server route -> data plugin (elastic#53191)
a13783a 
* value suggestions server route -> data plugin

Closes elastic#52842

* fix PR comments

* fix PR comments
alexwizp added a commit that referenced this issue Dec 18, 2019
@alexwizp
value suggestions server route -> data plugin (#53191) (#53456)
68be6fb 
* value suggestions server route -> data plugin

Closes #52842

* fix PR comments

* fix PR comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexwizp alexwizp

Labels
Feature:NP Migration
Projects
None yet
Milestone
No milestone
3 participants
@lukeelmers @elasticmachine @alexwizp