Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 'Are you sure?' dialog to dashboard delete #48

Closed
dwinter3 opened this issue Apr 17, 2013 · 2 comments
Closed

Add 'Are you sure?' dialog to dashboard delete #48

dwinter3 opened this issue Apr 17, 2013 · 2 comments
Labels
release_note:enhancement

Comments

@dwinter3
Copy link

Can you please add an "Are you sure?" dialog when deleting saved dashboards?
@cdeszaq
Copy link

cdeszaq commented Apr 17, 2013

Better yet would be the ability to undo a deletion within some time window. Don't pester the user if you don't have to.

@dwinter3
Copy link
Author

I don't 100% agree but either would be better than nothing. Thanks.

Sent from my iPhone

On Apr 17, 2013, at 10:31 AM, Rick Jensen [email protected] wrote:

Better yet would be the ability to undo a deletion within some time window. Don't pester the user if you don't have to.

—
Reply to this email directly or view it on GitHub.

faxm0dem pushed a commit to ccin2p3/kibana that referenced this issue Feb 17, 2014
@bazsi
Merge pull request elastic#48 from balabit/merge/h/improved-yacc-check
bb3d772 
configure.ac: Improve the bison version check
rashidkpc pushed a commit that referenced this issue Oct 6, 2014
Get rid of click-to-change-title in dashboard. Make searching better. C…
b403ec3 
…loses #48
rashidkpc pushed a commit that referenced this issue Oct 6, 2014
Get rid of click-to-change-title in dashboard. Make searching better. C…
b469f14 
…loses #48
spalger added a commit to spalger/kibana that referenced this issue Mar 3, 2016
@spalger
Merge pull request elastic#48 from spalger/layoutTweaks
75bebdc 
Layout tweaks
@KnightOfNight KnightOfNight mentioned this issue Jul 19, 2016
Closed
orouz pushed a commit to orouz/kibana that referenced this issue Jan 13, 2022
@JordanSh @orouz
removed accumulated dashbaord section (elastic#48)
95e46b9
ari-aviran pushed a commit to ari-aviran/kibana that referenced this issue Feb 7, 2022
@JordanSh @orouz
removed accumulated dashbaord section (elastic#48)
bb0f840
kqualters-elastic pushed a commit to kqualters-elastic/kibana that referenced this issue Mar 8, 2022
@opauloh
Updating Session View index to work with endpoint integration (elasti…
7f991aa 
…c#48)
alexwizp added a commit to alexwizp/kibana that referenced this issue Sep 30, 2024
@alexwizp
Merge branch 'main' into elastic#48
5a0119e
alexwizp added a commit to alexwizp/kibana that referenced this issue Oct 1, 2024
@alexwizp
Merge branch 'main' into elastic#48
d02eeba
alexwizp added a commit to alexwizp/kibana that referenced this issue Oct 1, 2024
@alexwizp
Merge branch 'main' into elastic#48
23557f5
alexwizp added a commit to alexwizp/kibana that referenced this issue Oct 1, 2024
@alexwizp
Merge branch 'main' into elastic#48
5ce64d9
alexwizp added a commit that referenced this issue Oct 1, 2024
@alexwizp
fix: [Obs Cases][SCREEN READER] Multiple single-item lists should be …
ee1efe4 
…consolidated into one meaningful list: 0002 (#194430)

Closes: elastic/observability-accessibility#48
Closes:
elastic/observability-accessibility#133

# Description 
Observability has a number of description lists that are used to
identify important key-value pairs for users. Visually these look like a
single list of pairs, but they are coded as multiple single item lists.
This is potentially confusing to screen reader users because these data
points are related and should be in a single, consolidated list.

# What was changed: 

1. Addressed [Issue
#48](elastic/observability-accessibility#48),
which recommended using a single EuiDescriptionList. However, following
the EUI guidelines, for this type of case, it is more appropriate to use
EuiFlexGroup with EuiStats. See the relevant documentation
[here](https://eui.elastic.co/#/display/stat). This PR implements the
suggested change accordingly.

2. To fix
elastic/observability-accessibility#133
aria-label attribute was added for `EuiIconTip`

# Screen: 

> [!NOTE]
> No UI changes


![image](https://github.com/user-attachments/assets/8d516337-45fb-4a86-80fd-9936bfb8f508)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Oct 1, 2024
@alexwizp
fix: [Obs Cases][SCREEN READER] Multiple single-item lists should be …
1851f9f 
…consolidated into one meaningful list: 0002 (elastic#194430)

Closes: elastic/observability-accessibility#48
Closes:
elastic/observability-accessibility#133

# Description
Observability has a number of description lists that are used to
identify important key-value pairs for users. Visually these look like a
single list of pairs, but they are coded as multiple single item lists.
This is potentially confusing to screen reader users because these data
points are related and should be in a single, consolidated list.

# What was changed:

1. Addressed [Issue
elastic#48](elastic/observability-accessibility#48),
which recommended using a single EuiDescriptionList. However, following
the EUI guidelines, for this type of case, it is more appropriate to use
EuiFlexGroup with EuiStats. See the relevant documentation
[here](https://eui.elastic.co/#/display/stat). This PR implements the
suggested change accordingly.

2. To fix
elastic/observability-accessibility#133
aria-label attribute was added for `EuiIconTip`

# Screen:

> [!NOTE]
> No UI changes

![image](https://github.com/user-attachments/assets/8d516337-45fb-4a86-80fd-9936bfb8f508)

(cherry picked from commit ee1efe4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
release_note:enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cdeszaq @dwinter3 and others