Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] Revisit descriptions for data sources #44347

Closed
gchaps opened this issue Aug 29, 2019 · 11 comments
Closed

[Maps] Revisit descriptions for data sources #44347

gchaps opened this issue Aug 29, 2019 · 11 comments
Assignees
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation discuss

Comments

@gchaps
Copy link
Contributor

gchaps commented Aug 29, 2019

Upload GeoJSON was recently added to Sources, but its description doesn't follow the same pattern as the other data sources:

Screen Shot 2019-08-28 at 11 45 50 AM

It's important to include "Upload", but it's also inconsistent with the text for the rest of the sources because it's not like any of the others. The others work with pre-existing data and this is creating a new index on the fly from your data so it kind of sticks out.

Also, there's a type down lower "Custom Vector Shapes" which is also technically from a GeoJSON Vector File.

What's the best text for this data and do we need to update any other descriptions?

@gchaps gchaps added discuss [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation labels Aug 29, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis

@kindsun
Copy link
Contributor

kindsun commented Aug 29, 2019

This is following up on a conversation @gchaps and I had. "Upload GeoJSON Vector File" is kind of a mouthful. It seems like the word "Vector" at the very least could be removed but then we'd want to be consistent with the rest.

I took a look over our current wording and order and this is what I'd personally revise it to. I think there's a perception that we're not showcasing our best features if we don't place them towards the top, but as a user, I'd definitely prefer to see like-things clustered, that way when I think "I'd like to add a vector layer" or "What are my basemap options?", all my options are right there together. Even using and working on this everyday, I find myself having to read and think about the descriptions for some of them to remind myself which one they are. I also remember that we removed "EMS" from several titles before. Personally, I think there's value in putting it in the titles so I did, but feel free to disagree!

  • Vector shapes EMS Boundaries
    Vector shapes of a Administrative boundaries vector data from Elastic Maps Service

  • Uploaded GeoJSON vector file (BETA)
    Upload & index GeoJSON as vector data in Elasticsearch and add as Documents

  • Custom vector shapes Configured GeoJSON
    Vector data from hosted GeoJSON files configured in kibana.yml

  • Documents
    Geospatial Vector data from a Kibana index pattern

  • Grid aggregation
    Geospatial data grouped in grids with metrics for each gridded cell (This could be more descriptive but I don't know how yet)

  • Source-destination connections
    Aggregated data paths between the origin and destinations.

  • Tiles EMS Basemaps
    Map tiles from Elastic Maps Service

  • Tile Map Service from URL
    Map tiles service from a URL that includes the XYZ coordinates entered via the Maps interface

  • Custom Configured Tile Map Service
    Map tiles service configured in kibana.yml

  • Web Map Service
    Maps from OGC Standard WMS entered via the Maps interface

Anyway, just trying to get the ball rolling. I'm sure we can improve on it!

@gchaps
Copy link
Contributor Author

gchaps commented Aug 29, 2019

great start @aaronjcaldwell . @nreese Can you also add the Connection data source to the list?

@nreese
Copy link
Contributor

nreese commented Aug 29, 2019

@nreese Can you also add the Connection data source to the list

Updated #44347 (comment) by adding Connection data source

@alexfrancoeur
Copy link

I'm behind on commenting on this, but have we determined what we'll use for the "Source-destination" data source? Is this the "connection" data source that's referenced? We discussed "Point to point" as an option here: #41575.

@gchaps
Copy link
Contributor Author

gchaps commented Sep 3, 2019

I like Alex's suggestion because the description itself includes "source and destination." Here is an updated version with Aaron and Alex's comments and a few of edits/questions for consistency.

  • EMS Boundaries
    Administrative boundaries for vector data from Elastic Maps Service (can we break up the noun phrase)?

  • Uploaded GeoJSON (BETA)
    Upload and index GeoJSON as vector data in Elasticsearch and add as Documents (ok to remove?)

  • Configured GeoJSON
    Vector data from hosted GeoJSON configured in kibana.yml

  • Documents
    Vector data from a Kibana index pattern

  • Grid aggregation
    Geospatial data grouped in grids with metrics for each gridded cell (agree this one can be better)

  • Point to point
    Aggregated data paths between source and destination

  • EMS Basemaps
    Map tiles from Elastic Maps Service

  • Tile Map Service
    Map tiles service entered via the Maps interface (title is "Tile Map" & description is reverse "Map tiles" OK?)

  • Configured Tile Map Service
    Map tiles service configured in kibana.yml

  • Web Map Service
    OGC Standard WMS entered via the Maps interface

@nreese
Copy link
Contributor

nreese commented Sep 3, 2019

sounds great. I really like the copy updates.

I don't like the ordering updates. I think its important that Elasticsearch sources stay at the top since those will be the most used. How about we just make the text updates in a PR and then circle back for the order updates since those are more controversial?

@alexfrancoeur
Copy link

👍 to that suggestion

@alexfrancoeur
Copy link

can we close this out now? Looks like the changes have been merged.

@nreese
Copy link
Contributor

nreese commented Sep 16, 2019

can we close this out now

We have not addressed the re-ordering of the list yet

@nreese
Copy link
Contributor

nreese commented Apr 12, 2021

Closing, most renames have been addressed

@nreese nreese closed this as completed Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation discuss
Projects
None yet
Development

No branches or pull requests

5 participants