-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] Revisit descriptions for data sources #44347
Comments
Pinging @elastic/kibana-gis |
This is following up on a conversation @gchaps and I had. "Upload GeoJSON Vector File" is kind of a mouthful. It seems like the word "Vector" at the very least could be removed but then we'd want to be consistent with the rest. I took a look over our current wording and order and this is what I'd personally revise it to. I think there's a perception that we're not showcasing our best features if we don't place them towards the top, but as a user, I'd definitely prefer to see like-things clustered, that way when I think "I'd like to add a vector layer" or "What are my basemap options?", all my options are right there together. Even using and working on this everyday, I find myself having to read and think about the descriptions for some of them to remind myself which one they are. I also remember that we removed "EMS" from several titles before. Personally, I think there's value in putting it in the titles so I did, but feel free to disagree!
Anyway, just trying to get the ball rolling. I'm sure we can improve on it! |
great start @aaronjcaldwell . @nreese Can you also add the Connection data source to the list? |
Updated #44347 (comment) by adding Connection data source |
I'm behind on commenting on this, but have we determined what we'll use for the "Source-destination" data source? Is this the "connection" data source that's referenced? We discussed "Point to point" as an option here: #41575. |
I like Alex's suggestion because the description itself includes "source and destination." Here is an updated version with Aaron and Alex's comments and a few of edits/questions for consistency.
|
sounds great. I really like the copy updates. I don't like the ordering updates. I think its important that Elasticsearch sources stay at the top since those will be the most used. How about we just make the text updates in a PR and then circle back for the order updates since those are more controversial? |
👍 to that suggestion |
can we close this out now? Looks like the changes have been merged. |
We have not addressed the re-ordering of the list yet |
Closing, most renames have been addressed |
Upload GeoJSON was recently added to Sources, but its description doesn't follow the same pattern as the other data sources:
It's important to include "Upload", but it's also inconsistent with the text for the rest of the sources because it's not like any of the others. The others work with pre-existing data and this is creating a new index on the fly from your data so it kind of sticks out.
Also, there's a type down lower "Custom Vector Shapes" which is also technically from a GeoJSON Vector File.
What's the best text for this data and do we need to update any other descriptions?
The text was updated successfully, but these errors were encountered: