-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move src/legacy/server/index_patterns
to data plugin (server)
#44190
Comments
Pinging @elastic/kibana-app-arch |
Most of the TODOs are done. One thing left is half of the last TODO "whether we can replace this by providing a scoped instance of IndexPatternsService via the handler context pattern, available in the core.context service." I left that out because currently we cannot be sure that is necessary for plugins and services. |
@sainthkh I think there are also a few calls for the _fields_for_wildcard API left. |
@lizozom You're right. There's only one case left in It can be removed when we can import Note: When you search |
Now that #55606 is merged, I believe we can safely remove |
_fields_for_wildcard
and_fields_for_time_pattern
routes and replace with usages ofIndexPatternsService
(server), orindex_patterns_api_client
(client).errors.js
to TSresolve_time_pattern.js
to TScore.http
& convert to TS[ ] Leave behind legacyindexPatternsServiceFactory
for backwards compatibility, and instead look into whether we can replace this by providing a scoped instance ofIndexPatternsService
via the handler context pattern, available in the core.context servicesrc/legacy/server/index_patterns
as it should no longer be in use anywhere in Kibana (and of course triple check that this is correct).Part of #43438
The text was updated successfully, but these errors were encountered: