Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Accessibility) Kibna Logs - Configure Source flyout does not properly label field groups #40419

Closed
barlowm opened this issue Jul 5, 2019 · 1 comment
Closed

(Accessibility) Kibna Logs - Configure Source flyout does not properly label field groups #40419

barlowm opened this issue Jul 5, 2019 · 1 comment
Assignees
@Kerry350
Labels
Feature:Logs UI Logs UI feature Project:Accessibility Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services WCAG A

Comments

@barlowm
Copy link
Collaborator

barlowm commented Jul 5, 2019

[Please add a WCAG level label: WCAG A/AA/AAA]

Steps to reproduce

  1. Navigate to the Kibana Logs page
  2. Click the "Configuragion" button to open the "Configure Source" flyout.

Untitled

Fields are grouped under <h3> tags. But should also use grouping roles to identify groups of fields

Example
Add role and labelledby and add ID to the h3 tag

<div role="group" `aria-labelledby="GROUP_1"` class="euiForm">
    <h3 `id="GROUP_1"` class="euiTitle euiTitle--small" data-test-subj="sourceConfigurationNameSectionTitle">Name</h3>

Meta Issue
Accessibility Audit for Kibana 7.0

Kibana Version:
7.2

OS:
Tested on Windows 7. But issue exists in all OS's

Browser:
Tested in Chrome. But issue exists in all Browsers

Screen reader: [if relevant]
N/A

Relevant WCAG Criteria: WCAG Criterion
1.3.1 Info and Relationships - Leval A
Information, structure, and relationships conveyed through presentation can be programmatically determined or are available in text.

3.3.2 Labels or Instructions - Level A
Labels or instructions are provided when content requires user input.

Relevant ARIA spec: WAI-ARIA Authoring Practices 1.1
ARIA17: Using grouping roles to identify related form controls
@sgrodzicki sgrodzicki added the Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services label Jul 11, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/infra-logs-ui

@Kerry350 Kerry350 self-assigned this Jul 22, 2019
Kerry350 added a commit to Kerry350/kibana that referenced this issue Jul 24, 2019
@Kerry350
Fixes elastic#40419 - Make use of EuiDescribedFormGroup in the source…
5075777 
… configuration panel
@Kerry350 Kerry350 mentioned this issue Jul 24, 2019
Merged
2 tasks
Kerry350 added a commit to Kerry350/kibana that referenced this issue Jul 30, 2019
@Kerry350
Revert "Fixes elastic#40419 - Make use of EuiDescribedFormGroup in th…
6e64d3a 
…e source configuration panel"

This reverts commit 5075777.
Kerry350 added a commit to Kerry350/kibana that referenced this issue Aug 2, 2019
@Kerry350
[InfraUI] [LogsUI] Accessibility fixes (elastic#41883)
93a7564 
* Fixes elastic#40411 - Add aria-label to search input

* Fixes elastic#40425 - Align gear icon aria-labels

* Fixes elastic#40419 - Make use of EuiDescribedFormGroup in the source configuration panel

* Add data-test-subj attribute back for functional test

* Revert "Fixes elastic#40419 - Make use of EuiDescribedFormGroup in the source configuration panel"

This reverts commit 5075777.
Kerry350 added a commit that referenced this issue Aug 5, 2019
@Kerry350
[InfraUI] [LogsUI] Accessibility fixes (#41883) (#42514)
a70145e 
* Fixes #40411 - Add aria-label to search input

* Fixes #40425 - Align gear icon aria-labels

* Fixes #40419 - Make use of EuiDescribedFormGroup in the source configuration panel

* Add data-test-subj attribute back for functional test

* Revert "Fixes #40419 - Make use of EuiDescribedFormGroup in the source configuration panel"

This reverts commit 5075777.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Kerry350 Kerry350

Labels
Feature:Logs UI Logs UI feature Project:Accessibility Team:Infra Monitoring UI - DEPRECATED DEPRECATED - Label for the Infra Monitoring UI team. Use Team:obs-ux-infra_services WCAG A
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@Kerry350 @sgrodzicki @barlowm @elasticmachine